Russell Peters wrote: > I hope to complete porting your changes to ZipMaster and there are few > things (some unrelated) that you might want to check - > DiskFreeAndSize - check bug for call to getfreediskspaceex ,it > returns true ok not error (same as getfreediskspace) Checked and changed > Avoid specifying Winzip type names (they may not mind but it is > copyright) after type AddSpanCompatName a couple of times I think > perhaps AddSpanAltNames (spAltNames) may be easier (could not > remember if was AddSpanCompatibleName or whatever). Will change the name > There seems to more function duplication added for using different > naming schemes perhaps a new function (or 2) could be added - that > way problems could be tackled in one place instead of many). > Do we need to keep checking the drive type? - I would not have > thought it could be changed readily, at least not as we use fixed or > removable (I doubt can be changed short of rebooting!) (also > mem_drive should be included as a fixed type) I was already thinking about using a new function and perhaps checking the drive type often can be avoided Didn't think about mem_drive, will add this one too Since the naming schemes seems to work now I can concentrate on this kind of things Thanks for the advice > Keep up the good work. > Russell Peters > http://www.users.bigpond.com/russellpeters/delphizip.html > ----- Original Message ----- > From: "Roger Aelbrecht" <Roger.Aelbrecht@xxxxxxxxxx> > To: <delphizip@xxxxxxxxxxxxx> > Sent: Wednesday, December 11, 2002 4:39 AM > Subject: [delphizip] AddSpanOptions > > >> >> A few days ago Russell suggested to add a new property SpanOptions: >> >> <quote> >> >> Thought new add option (also needed for splitting zips) >> AddSpanNoVolumeName (don't change/use disk volume name), >> AddSpanCompatName (make Winzip type names), AddSpanNoWipe (format >> don't wipe disk). Could use new property SpanOptions: AddOptions >> (defaults for spanning actions - when directly making spanned set >> gets copy of AddOptions) but could just use AddOptions instead (but >> readspan may need some settings and it does not add!). >> >> </quote> >> >> I will implement a new set call SpanOpts that contains >> spNoVolumeName, spCompatName, spNoWipe >> options that can be used by both write and read operations. >> The existing AddDiskSpan and AddDiskSpanErase can be left in the >> AddOpts for backward compatibility >> >> This way we have the separate span properties and avoid a bool >> property for each separately >> >> Started to implement a new read-only property "Busy" that is set for >> each public method in the component. >> Leave the ZipBusy and UnzBusy in for compatibility reasons >> >> >> BTW found a bug in TZipBuilder introduced in 1.70 that can have >> influence on the reported error with UnzBusy >> In ZipBuilder.h we have: >> __property bool UnzBusy = {read=FZipBusy, >> nodefault}; >> >> This should be : >> __property bool UnzBusy = {read=FUnzBusy, >> nodefault}; >> >> No idea how this happened >> >> >> Regards >> >> Roger Aelbrecht >> http://web.wanadoo.be/driehoeksw