Re: [yoshimi-user] Some optimization patches for Yoshimi

  • From: Kristian Amlie <kristian@xxxxxxxxxx>
  • To: yoshimi-user@xxxxxxxxxxxxxxxxxxxxx
  • Date: Thu, 11 Oct 2012 18:14:28 +0200

On 10/10/12 23:16, Will J Godfrey wrote:

On Sun, 07 Oct 2012 01:56:25 +0200
Kristian Amlie<kristian@xxxxxxxxxx> wrote:

On 10/06/12 19:45, Will J Godfrey wrote:
<snip>
I'll try to find time to check this out myself tomorrow, but I don't seem to
have much success applying patches :(

Hmm, strange... Did you try git-am?

I don't even know what git-am is! or how to use it. I'd been trying to use the
'patch' command, but it seems everyone has different ideas as to what directory
you should be in, and I can never work it out from the files themselves.

Heh, yeah Git is like that. It is powerful once you have mastered it, but it has a user interface like the cockpit of a plane: Hundreds of buttons and nothing but a cryptic manual to help you.

git-am is a command that takes a special patch file, generated by Git, and makes a new commit out of it. So it both patches AND commits for you (but it doesn't "git push", so you can still undo). This way you can preserve the commit message and timestamp of the person who made the patch, so you don't have to write it yourself. The patches I sent should be usable with git-am.

I you prefer the "patch" way, I believe the recommended workflow is:

1. Go the topmost directory of the project (the directory where the "INSTALL" file is).
2. $ patch -p1 < patch-file.patch

I've not actually had time to do anything anyway. Apart from anything else I
had an inspiration 'hit' over the weekend - hence 'Solo' in another thread and
what free time I've had has been absorbed by developing that.

It's easy to lose track of time when playing with Yoshimi!

--
Kristian


Other related posts: