Re: Yadex Patches
- From: Andrew Apted <aapted@xxxxxxxxxxxxxxx>
- To: yadex@xxxxxxxxxxxxx
- Date: Mon, 5 Jan 2004 15:50:13 +1100
On Sun, Jan 04, 2004 at 04:11:49PM -0700, Barry Mead wrote:
> Cool: This is a great web page. I love your 3d rendering patch.
> I have only three suggestions to help make the page a little better.
>
> 1. Give the patching and compiling instructions i.e
Done.
> 2. Add Andre's dependancy patch so the compile won't fail.
Done, though I expect it to appear on Andre's main page
(perhaps as Yadex 1.7.1) pretty shortly.
> 3. Add the R command and the internal rendering key commands(d,c,n,m,t,s,q)
> to
> the help text or man page for yadex.
It comes with documentation (preview.html), but the patch didn't
update the makefile to get it moved properly into doc/. Fixed.
> Thanks again for consolidating my find patch and adding it to your web page.
A few comments about your patch:
(a) the standard output from diff (ed format) is hard to read and
less robust. Please use "diff -u" (unified format).
(b) having all the files in one diff is better than separate diffs.
I usually rename the base directory e.g. to yadex-1.7.0-foo (the
one you've edited), unpack the original "next" to it, and do:
diff -u -r yadex-1.7.0 yadex-1.7.0-foo > FOO.diff
(c) if you have nothing highlighted and the find fails, then it
jumps to an arbitrary object. Would be better if it beeped,
or did nothing.
Cheers,
--
Andrew Apted <ajapted@xxxxxxxxxxxxxxxxxxxxx>
Other related posts:
