Hello list.
Here is another small job, which provides an opportunity to practice a little
SQL and git. A user has pointed out that RackTables misses a few port types,
which are called "outer interfaces" in RackTables:
https://bugs.racktables.org/view.php?id=1645
Obviously, this requires 4 extra rows in the PortOuterInterface table. A few
less obvious changes should be:
* a few extra rows in PortCompat to allow the new port types link between
themselves (downlink to uplink and the other way round)
* a few extra rows in PortInterfaceCompat to enable the new port types for
SFP-1000 (see PortInnerInterface)
* a few extra rows in PatchCableOIFCompat to enable the new port types for
"simplex OS1" and "simplex OS2" fibre cable types (see PatchCableType)
The extra rows in install.php would be just additional lines in existing
queries -- a straightforward change; in upgrade.php this would require a few
standalone INSERT queries.
And, of course, there should be a line in ChangeLog with a brief summary, the
ticket ID (#1645) and the name of the contributor that made it work.
It should help to remind that RackTables uses unit tests (tip of the hat to
Aaron for bootstrapping this). When somebody opens a GitHub pull request, in a
few minutes Travis CI automatically updates its status and in case of a failure
send an email. The tests coverage is still far from perfect, but simple errors
like comma/parenthesis issue or a foreign key mismatch are very likely to fail
the test, so in this specific case you can have the extra peace of mind.
Any questions -- feel free to ask.
--
Denis Ovsienko
