[racktables-users] Re: Update for snmp.php to include HP Procurves

  • From: Denis Ovsienko <infrastation@xxxxxxxxx>
  • To: "racktables-users@xxxxxxxxxxxxx" <racktables-users@xxxxxxxxxxxxx>
  • Date: Sat, 26 May 2012 23:20:58 +0400

22.05.2012, 22:03, "Jason Hamilton" <jason@xxxxxxxxxxxxxxxxxx>:
> Hi,
>
> I'd like to submit for review, the following patch to snmp.php for the hp 
> procurve switches we use in our environment.
> Applied and working in 0.19.12.
>

Hello, Jason.

Please see below.

> --- snmp.php.original   2011-07-19 20:06:35.000000000 -0500
> +++ snmp.php-updated    2011-08-03 11:30:44.000000000 -0500
> @@ -784,24 +784,54 @@ $known_switches = array // key is system
>                'text' => 'N5K-C5010: 20 SFP+/10000',
>                'processors' => array ('nexus-any-10000SFP+', 'nexus-mgmt'),
>        ),
> +       '11.2.3.7.11.31' => array
> +       (
> +               'dict_key' => 870,
> +               'text' => 'J4903A: 24 RJ-45/10-100-1000T(X)',
> +               'processors' => array ('procurve-chassis-1000T'),
> +       ),

This item looks OK.

>        '11.2.3.7.11.32' => array
>        (
>                'dict_key' => 871,
>                'text' => 'J4904A: 48 RJ-45/10-100-1000T(X)',
>                'processors' => array ('procurve-chassis-1000T'),
>        ),
> +       '11.2.3.7.11.34' => array
> +       (
> +               'dict_key' => 864,
> +               'text' => 'J4900A: 24 RJ-45/10-100TX + 2 
> RJ-45/10-100-1000T(X)',
> +               'processors' => array ('procurve-25-to-26-1000T', 
> 'procurve-chassis-100TX'),
> +       ),

This too.

>        '11.2.3.7.11.36' => array
>        (
>                'dict_key' => 865,
>                'text' => 'J8164A: 24 RJ-45/10-100TX + 2 
> RJ-45/10-100-1000T(X)',
>                'processors' => array ('procurve-25-to-26-1000T', 
> 'procurve-chassis-100TX'),
>        ),
> +       '11.2.3.7.11.29' => array
> +       (
> +               'dict_key' => 866,
> +               'text' => 'J4899A: 48 RJ-45/10-100TX + 2 
> RJ-45/10-100-1000T(X)',
> +               'processors' => array ('procurve-49-to-50-1000T', 
> 'procurve-chassis-100TX'),
> +       ),

This one was added 4 months ago (see ticket #503).

> +       '11.2.3.7.11.44' => array
> +       (
> +               'dict_key' => 866,
> +               'text' => 'J4899A: 48 RJ-45/10-100TX + 2 
> RJ-45/10-100-1000T(X)',
> +               'processors' => array ('procurve-49-to-50-1000T', 
> 'procurve-chassis-100TX'),
> +       ),

Are you sure it is the same model as the previous item?

>        '11.2.3.7.11.35' => array
>        (
>                'dict_key' => 867,
>                'text' => 'J8165A: 48 RJ-45/10-100TX + 2 
> RJ-45/10-100-1000T(X)',
>                'processors' => array ('procurve-49-to-50-1000T', 
> 'procurve-chassis-100TX'),
>        ),
> +       '11.2.3.7.11.68' => array
> +       (
> +               'dict_key' => 873,
> +               'text' => 'J9050A: 48 RJ-45/10-100-1000T',
> +               'processors' => array ('procurve-chassis-1000T'),
> +       ),

This one looks OK.

>        '11.2.3.7.11.9' => array
>        (
>                'dict_key' => 1086,
-- 
 Denis Ovsienko

Other related posts: