[procps] Re: [PATCH] pmap: fix const warning
- From: Sami Kerola <kerolasa@xxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Thu, 26 Jan 2012 21:31:09 +0100
Craig,
Here's Mike, Samuli & Mike fixes in pullable format. I see that some
patches are about ncurses, which where extensively discussed earlier.
After these patches all seemed to compile, which is good enough to me.
The following changes since commit 8955ec26fecf367eafcbcddaf3276437abc5e4f3:
Merge remote-tracking branch 'sami/vapier' (2012-01-24 22:36:28 +1100)
are available in the git repository at:
git://gitorious.org/~kerolasa/procps/sami-procps-ng.git to-craig
Mike Fleetwood (2):
tests: add SCHED_BATCH test
ps: display the nice value for processes with the SCHED_BATCH
scheduler policy
Mike Frysinger (4):
pmap: fix const warning
fix printf format warnings
fix AC_ARG_WITH(ncurses) handling
use pkg-config for ncurses by default
Samuli Suominen (1):
fix basic ncurses check
configure.ac | 25 +++++++++++++--------
pgrep.c | 2 +-
pmap.c | 2 +-
ps/output.c | 6 ++++-
testsuite/.gitignore | 1 +
testsuite/Makefile.am | 5 ++++
testsuite/ps.test/ps_sched_batch.exp | 12 ++++++++++
testsuite/ps.test/test-schedbatch.c | 39 ++++++++++++++++++++++++++++++++++
vmstat.c | 2 +-
w.c | 2 +-
10 files changed, 81 insertions(+), 15 deletions(-)
create mode 100644 testsuite/ps.test/ps_sched_batch.exp
create mode 100644 testsuite/ps.test/test-schedbatch.c
On Tue, Jan 24, 2012 at 18:56, Mike Frysinger <vapier@xxxxxxxxxx> wrote:
> pmap.c:300:8: warning: assignment discards 'const' qualifier
> from pointer target type [enabled by default]
>
> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> ---
> pmap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/pmap.c b/pmap.c
> index 3296ea7..1f42bec 100644
> --- a/pmap.c
> +++ b/pmap.c
> @@ -161,7 +161,7 @@ static int one_proc(proc_t * p)
> unsigned long total_private_writeable = 0ul;
> KLONG diff = 0;
>
> - char *cp2 = NULL;
> + const char *cp2 = NULL;
> unsigned long long rss = 0ull;
> unsigned long long private_dirty = 0ull;
> unsigned long long shared_dirty = 0ull;
> --
> 1.7.8.3
>
>
--
Sami Kerola
http://www.iki.fi/kerolasa/
Other related posts:
