[procps] Re: Need help with the build
- From: Jaromir Capik <jcapik@xxxxxxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Wed, 05 Oct 2011 06:42:03 -0400 (EDT)
Woohoo, thanks man!
As these are not in the 'master' yet, I'll alter the package build later.
I'm gonna ask my colleagues to search for memory errors / leaks
and do a static code analysis in the meantime.
The former version of procps had quite poor results and it would
be nice to get rid of all forgotten issues.
However ... Is there anything I could help with?
My knowledge of autotools is just basic and thus I'm affraid
I'm unable to decide anything related to this stuff.
I could say the same about git. I've never done rebasing
and as I was always affraid of breaking things, I stuck
with immediate pull/edit/commit/push actions in the 'master' once
the patch is accepted.
It seems I would have to find more time to play with the mentioned
git features.
Once again, thanks.
Jaromir.
----- Original Message -----
From: "Sami Kerola" <kerolasa@xxxxxx>
To: procps@xxxxxxxxxxxxx
Sent: Tuesday, October 4, 2011 8:58:16 PM
Subject: [procps] Re: Need help with the build
On Tue, Oct 4, 2011 at 18:18, Jaromir Capik <jcapik@xxxxxxxxxx> wrote:
> There's just one thing I'd like to know.
> The former version of procps had the following option
> of the 'make' command:
> SKIP="/bin/kill /usr/share/man/man1/kill.1"
>
> Whilst the new one doesn't support that. Of course I can delete
> the files after the build, but if there's any "official" way
> how to skip these, I'd like to use it.
Seem that you are looking for --disable-kill, see pull request bellow.
> I'm also thinking how to deal with the rest of options
> (haven't checked if they are still supported) :
>
> SHARED=1 ... I believe this can be skipped, because it's a default
> behavior now (On the other hand I'll have to use
> --disable-static or --enable-static=no for skipping
> the static library.
> CFLAGS="$RPM_OPT_FLAGS"
> W_SHOWFROM=-DW_SHOWFROM
That feels wrong, how about having --enable-w-from, see pull request bellow.
> ldconfig=true
Make install is helping you a little with that; see `libtool will
perform any necessary blessing during installation' form
http://sourceware.org/autobook/autobook/autobook_80.html
> install="install -D"
I've never needed to give any install flags when using autotools.
-- pull request --
The following changes since commit 367fd902dab64b51ba49709004b5011440e3105a:
build-sys: add ./configure --enable-oomem option (2011-09-29 20:28:31 +0200)
are available in the git repository at:
git://gitorious.org/~kerolasa/procps/sami-procps-ng.git ng
Sami Kerola (2):
build-sys: add --disable-kill build option
build-sys: add --enable-w-from build option
Makefile.am | 9 +++++----
configure.ac | 14 ++++++++++++++
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 890f71b..82ac8e6 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -9,9 +9,6 @@ AM_LDFLAGS = ./proc/libproc-ng.la
sbin_PROGRAMS = \
sysctl
-bin_PROGRAMS = \
- kill
-
usrbin_exec_PROGRAMS = \
free \
pgrep \
@@ -27,7 +24,6 @@ usrbin_exec_PROGRAMS = \
dist_man_MANS = \
free.1 \
- kill.1 \
pgrep.1 \
pkill.1 \
pmap.1 \
@@ -41,6 +37,11 @@ dist_man_MANS = \
vmstat.8 \
w.1
+if BUILD_KILL
+bin_PROGRAMS = kill
+dist_man_MANS += kill.1
+endif
+
if HAVE_NCURSES
usrbin_exec_PROGRAMS += \
slabtop \
diff --git a/configure.ac b/configure.ac
index aa12405..183e24a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -142,6 +142,12 @@ if test "x$with_ncurses" != xno; then
fi
AC_SUBST([NCURSES_LIBS])
+AC_ARG_ENABLE([kill],
+ AS_HELP_STRING([--disable-kill], [do not build kill]),
+ [], enable_kill=yes
+)
+AM_CONDITIONAL(BUILD_KILL, test "x$enable_kill" = xyes)
+
AC_ARG_ENABLE([oomem],
AS_HELP_STRING([--enable-oomem], [add out-of-memory fields to the
library and top]),
[], enable_oomem=no
@@ -150,6 +156,14 @@ if test "x$enable_oomem" = xyes; then
AC_DEFINE(OOMEM_ENABLE, 1, [add out-of-memory fields to the library and top])
fi
+AC_ARG_ENABLE([w-from],
+ AS_HELP_STRING([--enable-w-from], [enable w from field by default]),
+ [], enable_w_from=no
+)
+if test "x$enable_w_from" = xyes; then
+ AC_DEFINE(W_SHOWFROM, 1, [enable w from field by default])
+fi
+
AC_CONFIG_FILES([
Makefile
proc/Makefile
--
Sami Kerola
http://www.iki.fi/kerolasa/
Other related posts:
