[pisa-src] Re: r894 - trunk/libpisa

  • From: Thomas Jansen <mithi@xxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Tue, 1 Sep 2009 18:38:29 +0200

On Tue, Sep 01, 2009 at 10:32:48AM +0200, Diego Biurrun wrote:

> > --- trunk/libpisa/pisaconf.c        Thu Aug 27 19:23:00 2009        (r893)
> > +++ trunk/libpisa/pisaconf.c        Mon Aug 31 12:18:01 2009        (r894)
> > @@ -117,7 +108,7 @@
> >  
> >      /* bind the socket with the local address */
> >      if ( bind(fd_peer, (struct sockaddr *)&sin, sizeof(sin)) < 0)
> > -        die("pisa_tunnel_open_socket: socket-bind failed",4);
> > +        die("pisa_conf_open_server_socket: socket-bind failed",4);
> 
> stray hunk?

That was a fix for a sloppy copy-paste. If you call die *and* specify the
function name explicity it should be updated when you copy-paste a function.
Or one could use __FUNCTION__.

Now I'm probably getting scolded for not breaking that up into two commits or
at least mentioning it in the commit log. ;)

-- 
Thomas Jansen, "Mithi" --- mithi@xxxxxxxxx
GPG 9D5C682B, feel free to sign or encrypt your mail

Other related posts: