[pisa-src] Re: r2775 - in trunk: Makefile.am community-operator/pisa-co-cgi.c community-operator/server community-operator/server/binary.c community-operator/server/call-hipconf.c community-operator/server/certif...

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Tue, 27 Mar 2012 16:07:04 +0200

On Wed, Oct 12, 2011 at 05:35:22PM +0200, Christoph Viethen wrote:
> 
> Log:
> Add new Community Operator server code.
>  
> --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> +++ trunk/community-operator/server/certificate.c     Wed Oct 12 17:35:17 
> 2011        (r2775)
> @@ -0,0 +1,41 @@
> +FILE *get_certificate(FILE *hipconf_pipe)

This is only used from one place, it should really be a static function
in that place instead.

> --- trunk/community-operator/pisa-co-cgi.c    Mon Oct 10 15:17:40 2011        
> (r2774, copy source)
> +++ trunk/community-operator/server/main.c    Wed Oct 12 17:35:17 2011        
> (r2775)
> @@ -1,536 +1,178 @@
>  
> +int main(void)
>  {
>  
> +    FILE *cert_pipe    = NULL;
>  
>  
> +    /* now parse whatever call_hipconf returned */
> +    cert_pipe = get_certificate(hipconf_pipe);

cert_pipe is write-only.  This will make the autobuilder bomb out once
passion is upgraded to gcc 4.6, which will happen any moment now.

Diego
-- 
This is the pisa developer mailing list. Please also subscribe to the main pisa 
list at:
//www.freelists.org/list/pisa

Other related posts: