[pisa-src] Re: r2111 - trunk/libpisa/dict.h

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Tue, 09 Mar 2010 16:57:10 +0100

On Tue, Mar 09, 2010 at 03:47:43PM +0100, Mircea Gherzan wrote:
> 
> Log:
> Add dictionary header, part of uthash replacement.
> 
> --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> +++ trunk/libpisa/dict.h      Tue Mar  9 15:47:43 2010        (r2111)
> @@ -0,0 +1,76 @@
> +
> +#ifndef _PISA_DICT_H
> +#define _PISA_DICT_H

This is wrong, identifiers starting with _ and uppercase letters or __
are reserved for the system.  Also, we use PISA_ as prefix everywhere
else, not _PISA_.

> +#endif // _PISA_DICT_H

nit: /* */ like everywhere else..

Diego

Other related posts: