[pisa-src] Re: r1738 - in trunk: auto-update/config/split-file auto-update/files/etc/banner auto-update/files/etc/config/dhcp auto-update/files/etc/config/firewall auto-update/files/etc/config/network auto-update...
- From: Tobias Heer <heer@xxxxxxxxxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Mon, 23 Nov 2009 12:06:57 +0100
Hi Diego,
Am 20.11.2009 um 16:30 schrieb Diego Biurrun:
> Author: biurrun
> Date: Fri Nov 20 16:30:16 2009
> New Revision: 1738
>
> Log:
> The grand reformatting, chapter I.
> Change tabs to spaces, remove all trailing whitespace;
> proper consistent coding style for shell scripts.
>
> Modified:
>
...
> trunk/docs/Doxyfile
> trunk/docs/architecture.txt
> trunk/docs/packettype.txt
> trunk/docs/porting_osx.txt
...
> trunk/openwrt/files/etc/pisa/pisacd.conf
> trunk/openwrt/package/hipl/Makefile
...
> trunk/openwrt/package/hipl/files/hipd.init
> trunk/openwrt/package/hipl/files/hipfw.init
> trunk/openwrt/package/hipl/files/hipl.modules
> trunk/openwrt/package/hipl/files/test/firewall.init
> trunk/openwrt/package/hipl/files/test/firewall.start
...
> trunk/openwrt/package/libxml2/Makefile
> trunk/openwrt/package/pisa/Makefile
You may have done too much. Not just .c and .h files were reformatted but
everything. Although that I agree that we should have a common style for
c-related files, using solely spaces causes trouble in other file types (e.g.
Makefiles). Can't we be more selective here?
BR,
Tobias
--
Dipl.-Inform. Tobias Heer, Ph.D. Student
Distributed Systems Group
RWTH Aachen University, Germany
tel: +49 241 80 207 76
web: http://ds.cs.rwth-aachen.de/members/heer
Other related posts:
