[pisa-src] r1616 - in trunk: pisacd/cdtun.c pisasd/sdtun.c
- From: Thomas Jansen <mithi@xxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Tue, 10 Nov 2009 17:15:35 +0100
Author: tjansen
Date: Tue Nov 10 17:15:34 2009
New Revision: 1616
Log:
Fixed signedness in comparisons.
OpenWrt complained like this:
pisacd/cdtun.c: In function 'pisa_cd_copy_from_sock_to_tun':
pisacd/cdtun.c:58: warning: comparison between signed and unsigned
pisasd/sdtun.c: In function 'pisa_sd_copy_from_sock_to_tun':
pisasd/sdtun.c:65: warning: comparison between signed and unsigned
Modified:
trunk/pisacd/cdtun.c
trunk/pisasd/sdtun.c
Modified: trunk/pisacd/cdtun.c
==============================================================================
--- trunk/pisacd/cdtun.c Tue Nov 10 17:09:53 2009 (r1615)
+++ trunk/pisacd/cdtun.c Tue Nov 10 17:15:34 2009 (r1616)
@@ -55,7 +55,7 @@
return;
}
- if (entry->data_port != ntohs(from.sin6_port)) {
+ if (entry->data_port != (int)ntohs(from.sin6_port)) {
PISA_DEBUG(PL_DATA, "Discarding data from the wrong
port!\n");
return;
}
Modified: trunk/pisasd/sdtun.c
==============================================================================
--- trunk/pisasd/sdtun.c Tue Nov 10 17:09:53 2009 (r1615)
+++ trunk/pisasd/sdtun.c Tue Nov 10 17:15:34 2009 (r1616)
@@ -62,7 +62,7 @@
return;
}
- if (entry->data_port != ntohs(from.sin6_port)) {
+ if (entry->data_port != (int)ntohs(from.sin6_port)) {
PISA_DEBUG(PL_DATA, "Discarding data from the wrong
port! expected: %i, is: %i\n", entry->data_port, ntohs(from.sin6_port));
return;
}
Other related posts:
- » [pisa-src] r1616 - in trunk: pisacd/cdtun.c pisasd/sdtun.c - Thomas Jansen
