[pisa-src] r1473 - in trunk/libpisa: global.h util.c

  • From: Tobias Heer <tobias.heer@xxxxxxxxxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Sun, 01 Nov 2009 23:12:37 +0100

Author: heer
Date: Sun Nov  1 23:12:37 2009
New Revision: 1473

Log:
Marked even more possible preauth remnants. Reopened the corresponding ticket: 
Ticket #102

Modified:
   trunk/libpisa/global.h
   trunk/libpisa/util.c

Modified: trunk/libpisa/global.h
==============================================================================
--- trunk/libpisa/global.h      Sun Nov  1 22:58:59 2009        (r1472)
+++ trunk/libpisa/global.h      Sun Nov  1 23:12:37 2009        (r1473)
@@ -168,7 +168,11 @@
 
 /**
  * Protocol definitions
+ * TODO: TH: possible preauth remnants (PISA_HIP*) - check dependencies and 
remove if possible
+ *              Almost everything crypto-related (SHA, AES, MD5, 3DES, ESP, 
HMAC, HASH, TOKEN) should be handled
+ *              by HIP and not PISA.
  */
+
 #define PISA_HIP_RESERVED                0
 #define PISA_HIP_AES_SHA1                1
 #define PISA_HIP_3DES_SHA1               2

Modified: trunk/libpisa/util.c
==============================================================================
--- trunk/libpisa/util.c        Sun Nov  1 22:58:59 2009        (r1472)
+++ trunk/libpisa/util.c        Sun Nov  1 23:12:37 2009        (r1473)
@@ -174,6 +174,8 @@
  *
  * @return the encryption key length based on the chosen transform,
  * otherwise < 0 on error.
+ *
+ * TODO: TH: possible preauth remnant - check dependencies and remove if 
possible
  */
 int pisa_enc_key_length(int tid){
        int ret = -1;
@@ -198,7 +200,9 @@
        return ret;
 }
 
-
+/**
+TODO: TH: possible preauth remnant - check dependencies and remove if possible
+**/
 int pisa_hmac_key_length(int tid){
        int ret = -1;
        switch(tid) {
@@ -226,6 +230,8 @@
  *
  * @return the authentication key length based on the chosen transform.
  * otherwise < 0 on error.
+ *
+ * TODO: TH: possible preauth remnant - check dependencies and remove if 
possible
  */
 int pisa_auth_key_length_esp(int tid){
        int ret = -1;
@@ -256,6 +262,8 @@
  *
  * @param buf  [out] buffer where generated random data will be stored
  * @param n    length of data that will be generated
+ *
+ * TODO: TH: possible preauth remnant - check dependencies and remove if 
possible
  */
 void pisa_get_random_bytes(void *buf, int n)
 {

Other related posts:

  • » [pisa-src] r1473 - in trunk/libpisa: global.h util.c - Tobias Heer