[pisa-src] r1471 - trunk/libpisa/global.h

  • From: Tobias Heer <tobias.heer@xxxxxxxxxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Sun, 01 Nov 2009 22:49:11 +0100

Author: heer
Date: Sun Nov  1 22:49:11 2009
New Revision: 1471

Log:
Added todo regarding maximum packet buffer size. This needs to be checked.

Modified:
   trunk/libpisa/global.h

Modified: trunk/libpisa/global.h
==============================================================================
--- trunk/libpisa/global.h      Sun Nov  1 22:42:49 2009        (r1470)
+++ trunk/libpisa/global.h      Sun Nov  1 22:49:11 2009        (r1471)
@@ -51,7 +51,12 @@
  * Maximum value for a normal packet buffer
  * A normal packet: 1500 - 20(IP) - 48(HIP) - 20(TCP/UDP) - 8(PISA header) = 
1404 bytes
  * This size cannot be more than that, because every PISA packet sent through
- * UDP must be fit into a single ethernet frame. 
+ * UDP must be fit into a single ethernet frame.
+ *
+ *TODO: TH: the assumption that packets cannot be larger than 1404 bytes is 
ill-advised.
+ *             Fragmentation and reassembly may lead to considerably larger 
packets. This value
+ *             needs to be revised.
+ *
  */
 #define MAX_PACKET_BUFFER      1404
 

Other related posts:

  • » [pisa-src] r1471 - trunk/libpisa/global.h - Tobias Heer