[pisa-src] Re: r1240 - in trunk/community-operator: Makefile.am co_client.c
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Tue, 20 Oct 2009 13:26:15 +0200
On Mon, Oct 19, 2009 at 10:47:11PM +0200, Jan Marten wrote:
>
> Log:
> Community-Operator client stores received certificates to a directory and
> checks periodically if a new certificate is required
The long lines in your commit messages make me believe that you pass the
-m switch to Subversion. You should use an editor instead. It's not
feasible to write good commit messages as an argument to a command line
program.
> --- trunk/community-operator/Makefile.am Mon Oct 19 21:51:52 2009
> (r1239)
> +++ trunk/community-operator/Makefile.am Mon Oct 19 22:47:11 2009
> (r1240)
> @@ -20,6 +20,7 @@
> INCLUDES += -I@PISA_HIPL_SRCDIR@/libhiptool
> INCLUDES += -I@PISA_HIPL_SRCDIR@/libdht
> INCLUDES += -I@PISA_HIPL_SRCDIR@/opendht
> +INCLUDES += -I@PISA_HIPL_SRCDIR@/firewall
> INCLUDES += -I@PISA_HIPL_SRCDIR@/hipd
> INCLUDES += -I@PISA_HIPL_SRCDIR@/i3/i3_client
> INCLUDES += -I@PISA_HIPL_SRCDIR@/pjproject/pjnath/include
All of this is very ugly.
Why don't we just use the full relative path in the #include statements?
> @@ -33,6 +34,13 @@
>
> +if PISA_WITH_HIPL
> +# TODO correct linking
> +# pisa_split_cert function is needed in co_client.c
> +# Do not know any better way so far.
> + co_client_LDADD = @PISA_HIPL_SRCDIR@/firewall/pisa_cert.o
> +endif
Why did you commit this *again*? I clearly said it was not the correct
solution already.
Diego
Other related posts:
