[pisa-src] Re: r1173 - Regression
- From: Thomas Jansen <mithi@xxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Fri, 16 Oct 2009 12:57:41 +0200
On Thu, Oct 15, 2009 at 04:15:24PM +0200, Diego Biurrun wrote:
> New Revision: 1173
>
> Log:
> Globally set default CFLAGS in configure.ac instead of duplicating them
> in each Makefile.am per subdirectory.
> Modified: trunk/configure.ac
> ==============================================================================
> --- trunk/configure.ac Thu Oct 15 15:48:43 2009 (r1172)
> +++ trunk/configure.ac Thu Oct 15 16:15:24 2009 (r1173)
> @@ -174,6 +174,7 @@
>
> # Our configuration files should be located in a subdirectory of their own.
> AC_SUBST(sysconfdir, ${sysconfdir}/pisa)
> +AC_SUBST(CFLAGS, "-g -O2 -Wall")
>
> # This is needed to export the _expanded_ value of the variable to
> ac_config.h.
> AC_DEFINE_UNQUOTED(PISA_SYSCONFDIR, "$(eval echo $sysconfdir)")
Regression: CFLAGS is overwritten instead of appended. This prevents me from
building with profiling support the way it used to work:
CFLAGS=-pg ./configure && make clean && make
Simply using AC_SUBST(CFLAGS, "$CFLAGS -g -O2 -Wall") results in
"-g -O2 -g -O2 -Wall" for a simple ./configure and in the expected
"-pg -g -O2 -Wall" for CFLAGS=-pg ./configure.
--
Thomas Jansen, "Mithi" --- mithi@xxxxxxxxx
GPG 9D5C682B, feel free to sign or encrypt your mail
Other related posts:
