[pisa-src] Re: r1152 - in trunk/community-operator: Makefile.am co_client.c co_client.cfg co_common_packets.h co_server.c hipl.c hipl.h
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Wed, 14 Oct 2009 23:57:48 +0200
On Wed, Oct 14, 2009 at 05:22:24PM +0200, Jan Marten wrote:
>
> Log:
> Added Community-Operator changes:
> - A protocol is introduced
> - Client checks periodically for new certificate
> - A request can be denied
> - changes which require the certificate changes in the HIPL code are added
> in ifdef blocks
This commit is *huge* and near unreviewable. You should split such
things into multiple parts.
> --- trunk/community-operator/Makefile.am Wed Oct 14 17:12:26 2009
> (r1151)
> +++ trunk/community-operator/Makefile.am Wed Oct 14 17:22:24 2009
> (r1152)
> @@ -42,6 +43,11 @@
>
> co_client_LDADD = $(LDADD) -lm -lcrypto
> +if PISA_WITH_HIPL
> +# TODO correct linking
> +# pisa_split_cert function is needed in co_client.c
> + co_client_LDADD += @PISA_HIPL_SRCDIR@/firewall/pisa_cert.o
> +endif
This is obviously not the correct solution.
> --- trunk/community-operator/co_client.c Wed Oct 14 17:12:26 2009
> (r1151)
> +++ trunk/community-operator/co_client.c Wed Oct 14 17:22:24 2009
> (r1152)
> @@ -3,17 +3,61 @@
> +
> +typedef struct co_client_conf
> +{
> +}
> +co_client_conf_t;
The _t namespace is reserved for POSIX, you should not use it.
Thomas worked on getting rid of all offenders, don't undo his work..
> - if ((s = socket(PF_INET6, SOCK_DGRAM, 0)) == 0) {
> + if ((s = socket(PF_INET6, SOCK_DGRAM, 0)) == 0)
> + {
This file was in K&R style previously, now it no longer is. Hmmm...
> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> +++ trunk/community-operator/co_common_packets.h Wed Oct 14 17:22:24
> 2009 (r1152)
> @@ -0,0 +1,61 @@
> +
> +#ifndef CO_COMMON_PACKETS_H
> +#define CO_COMMON_PACKETS_H
This is missing the PISA_ prefix.
> +#endif
A comment indicating which #ifdef this belongs to would be nice.
Diego
Other related posts:
