[pisa-src] Re: r1032 - in trunk: . pisabeacon
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Wed, 07 Oct 2009 13:15:52 +0200
On Wed, Oct 07, 2009 at 09:12:34AM +0200, Tobias Heer wrote:
>
> Am 06.10.2009 um 22:06 schrieb Diego Biurrun:
>
> >On Tue, Oct 06, 2009 at 09:18:20PM +0200, Tobias Heer wrote:
> >>
> >>Log:
> >>Added a sender/receiver component for testing the beaconing
> >>functionality. Functionality and code maturity are far from perfect.
> >
> >Hmmm, looks like you did not doublecheck the diff before committing..
>
> True, I take the blame.
Never mind.
Doublechecking commits by looking at the output of "svn diff" before
committing is a very useful habit. It saved me from embarassment
countless times.
Also, the first time I messed up at MPlayer, Arpi took me out in the
yarrd and beat me up ;)
> >>--- /dev/null 00:00:00 1970 (empty, because file is newly added)
> >>+++ trunk/pisabeacon/Makefile.am Tue Oct 6 21:18:19 2009 (r1032)
> >>@@ -0,0 +1,25 @@
> >>+#sysconfdir = /etc/pisa
> >
> >This is bad, it reintroduces the bug I just tried to fix:
> >Configuration file paths must not be hardcoded but set by configure.
> >
> You noticed that it's a comment?
Somewhat ;)
> >Recursive make must be eliminated in PISA. It just leads to bugs
> >getting copypasted around. I'll get to it.
>
> I'll take care of the issues and try to do better next time.
I'll try to get the build system fixed. People are bound to keep
falling into the traps it sets for the unsuspecting...
Diego
Other related posts:
