[nvda-addons] Re: commit/wintenApps: josephsl: Reverse the object lookup logic, otherwise certain gain focus events are not handled.

  • From: Noelia <nrm1977@xxxxxxxxx>
  • To: nvda-addons@xxxxxxxxxxxxx
  • Date: Sun, 28 Feb 2016 06:38:18 +0100

Hi, I have reviewed these commits.
SPL has a lot of code and I don't have enough time for its revision, but
this add-on seems very interesting, though I don't have Windows 10 now.
Code is right for me.
Thanks.


El 28/02/2016 a las 6:26, commits-noreply@xxxxxxxxxxxxx escribió:

1 new commit in wintenApps:

https://bitbucket.org/nvdaaddonteam/wintenapps/commits/c482a9f3b92e/
Changeset:   c482a9f3b92e
Branch:      stable
User:        josephsl
Date:        2016-02-28 05:26:08+00:00
Summary:     Reverse the object lookup logic, otherwise certain gain focus 
events are not handled.

Affected #:  1 file

diff --git a/addon/globalPlugins/wintenObjs.py 
b/addon/globalPlugins/wintenObjs.py
index 0404c03..9d90d97 100755
--- a/addon/globalPlugins/wintenObjs.py
+++ b/addon/globalPlugins/wintenObjs.py
@@ -70,8 +70,9 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
      # Focus announcement hacks.
      def event_gainFocus(self, obj, nextHandler):
              # Never allow WorkerW thread to send gain focus event (seen in 
Insider builds but was observed in release builds for some).
-             if obj.role != controlTypes.ROLE_PANE and obj.appModule != 
"explorer" and obj.windowClassName != "WorkerW":
-                     nextHandler()
+             if obj.role == controlTypes.ROLE_PANE and 
obj.appModule.appModuleName == "explorer" and obj.windowClassName == 
"WorkerW" and obj.name is None:
+                     return
+             nextHandler()
 
      def script_voiceActivation(self, gesture):
              gesture.send()

Repository URL: https://bitbucket.org/nvdaaddonteam/wintenapps/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.


----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting 
bugs. 

Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe: 
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx

Other related posts:

  • » [nvda-addons] Re: commit/wintenApps: josephsl: Reverse the object lookup logic, otherwise certain gain focus events are not handled. - Noelia