[nvda-addons] Re: commit/StationPlaylist: josephsl: 4.x/4.0-dev: removed script doc for connect/disconnect script to prevent them from being changed, and fixed an issue where input help message wasn't spoken for Shift+F11 command.
- From: "Joseph Lee" <joseph.lee22590@xxxxxxxxx>
- To: <nvda-addons@xxxxxxxxxxxxx>
- Date: Fri, 10 Oct 2014 13:55:37 -0700
Hi,
1. WinUser is a wrapper around user32.dll and is included with NVDA core.
2. I usually do not make strings translatable nor add translator comments
until much later after testing a feature for a long time.
Cheers,
Joseph
-----Original Message-----
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Noelia
Sent: Friday, October 10, 2014 1:44 PM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Re: commit/StationPlaylist: josephsl: 4.x/4.0-dev:
removed script doc for connect/disconnect script to prevent them from being
changed, and fixed an issue where input help message wasn't spoken for
Shift+F11 command.
Hi Joseph, many thanks
I have reviewed the SPLStudio app module:
1. Why is imported the whole module winUser? winUser. is not found, at least
I can't find it.
2. I find tho messages without gettext support.
Thanks.
El 09/10/2014 20:03, Joseph Lee escribió:
> Hi Noelia,
> Your review suggestions has been implemented - the scripts for
> connect/disconnect have their docstrings removed to prevent users from
> changing these commands.
> Cheers,
> Josehp
>
> -----Original Message-----
> From: nvda-addons-commits-bounce@xxxxxxxxxxxxx
> [mailto:nvda-addons-commits-bounce@xxxxxxxxxxxxx] On Behalf Of
> commits-noreply@xxxxxxxxxxxxx
> Sent: Thursday, October 9, 2014 11:03 AM
> To: nvda-addons-commits@xxxxxxxxxxxxx
> Subject: commit/StationPlaylist: josephsl: 4.x/4.0-dev: removed script doc
> for connect/disconnect script to prevent them from being changed, and
fixed
> an issue where input help message wasn't spoken for Shift+F11 command.
>
> 1 new commit in StationPlaylist:
>
> https://bitbucket.org/nvdaaddonteam/stationplaylist/commits/8d528b7e6cef/
> Changeset: 8d528b7e6cef
> Branch: master
> User: josephsl
> Date: 2014-10-09 18:02:08+00:00
> Summary: 4.x/4.0-dev: removed script doc for connect/disconnect script
> to prevent them from being changed, and fixed an issue where input help
> message wasn't spoken for Shift+F11 command.
>
> Affected #: 1 file
>
> diff --git a/addon/globalPlugins/SPLStudioUtils.py
> b/addon/globalPlugins/SPLStudioUtils.py
> index e9bd778..a701975 100644
> --- a/addon/globalPlugins/SPLStudioUtils.py
> +++ b/addon/globalPlugins/SPLStudioUtils.py
> @@ -291,15 +291,11 @@ class
GlobalPlugin(globalPluginHandler.GlobalPlugin):
> statusThread =
> threading.Thread(target=self.reportConnectionStatus)
> statusThread.name = "Connection Status Reporter"
> statusThread.start()
> - # Translators: Input help mode message in SAM Encoder
> window.
> - script_connect.__doc__=_("Connects to a streaming server.")
>
> def script_disconnect(self, gesture):
> gesture.send()
> # Translators: Presented when SAM Encoder is
> disconnecting from a streaming server.
> ui.message(_("Disconnecting..."))
> - # Translators: Input help mode message in SAM Encoder
> window.
> - script_disconnect.__doc__=_("Disconnects from a streaming
> server.")
>
> def script_toggleFocusToStudio(self, gesture):
> if not self.focusToStudio:
> @@ -339,7 +335,7 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
> # Translators: Presented when toggling the
> setting to switch to Studio when connected to a streaming server.
> ui.message(_("Do not play first track after
> connecting"))
> # Translators: Input help mode message in SAM Encoder
> window.
> - script_toggleFocusToStudio.__doc__=_("Toggles whether Studio
> will play the first song when connected to a streaming server.")
> + script_togglePlay.__doc__=_("Toggles whether Studio will
> play the
> +first song when connected to a streaming server.")
>
> def script_streamLabeler(self, gesture):
> curStreamLabel = ""
>
> Repository URL: https://bitbucket.org/nvdaaddonteam/stationplaylist/
>
> --
>
> This is a commit notification from bitbucket.org. You are receiving this
> because you have the service enabled, addressing the recipient of this
> email.
>
> ----------------------------------------------------------------
>
> NVDA add-ons Central: A list for discussing NVDA add-ons
>
> To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
>
> To unsubscribe, send an email with the subject line of "unsubscribe"
(without quotes) to nvda-addons-request@xxxxxxxxxxxxx.
>
> If you have questions for list moderators, please send a message to
nvda-addons-moderators@xxxxxxxxxxxxx.
>
> Community addons can be found here: http://addons.nvda-project.org
>
----------------------------------------------------------------
NVDA add-ons Central: A list for discussing NVDA add-ons
To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
To unsubscribe, send an email with the subject line of "unsubscribe"
(without quotes) to nvda-addons-request@xxxxxxxxxxxxx.
If you have questions for list moderators, please send a message to
nvda-addons-moderators@xxxxxxxxxxxxx.
Community addons can be found here: http://addons.nvda-project.org
----------------------------------------------------------------
NVDA add-ons Central: A list for discussing NVDA add-ons
To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
To unsubscribe, send an email with the subject line of "unsubscribe" (without
quotes) to nvda-addons-request@xxxxxxxxxxxxx.
If you have questions for list moderators, please send a message to
nvda-addons-moderators@xxxxxxxxxxxxx.
Community addons can be found here: http://addons.nvda-project.org
Other related posts:
