Hi again, sorry for my bad expression: I mean messages of scripts are
just spoken, not documentation.
It isn't used ui.message or braille.message.
Also, the add-on doesn't use profiles in a standard way. What if someone
changes something in a specific profile for MIRC, or if she or he
disables the triggers, etc.?
Another comment: If a script to review the bottom line of the current
object navigator is needed, shouldn't be assigned by default to the
corresponding gestures used in NVDA?
Of course, all this is optional.
Thanks.
El 15/11/2016 a las 21:28, Noelia escribió:
Hi, I like the add-on structure.----------------------------------------------------------------
My only comment, addressing the previous revision by Joseph, is:
Why messages of script documentation are just spoken, not displayed in
braille?
Also, I think they should be categorized to be found easily in the Input
gestures dialog.
Thanks.
El 15/11/2016 a las 21:12, Noelia escribió:
Hi, if you don't mind, I will see some of this since I'm interested on
style and you (Joseph) are mentioning this as an example.
I think that people who wants to learn should review this or other
add-ons. We need more reviewers.
I will look at MIRC, for example, and in case I have any comments I will
post it.
Thanks.
El 15/11/2016 a las 3:02, Joseph Lee escribió:
Hi everyone, including nick, reviewers and others,
I’d like to dedicate this thread to talking about nick’s add-ons,
particularly add-ons and app modules under review. To start with, here’s
the basic review results for mIRC and Mush client:
mIRC:
· License and copyright: pass.
· Documentation in code: pass with comments.
· Security: pass.
Comments:
· It might be helpful to provide translator comments for input
help messages, as well as a general readme file.
Mush client:
· License and copyright: pass.
· Documentation in code: pass with same comment as above.
· Security: pass.
Comment:
· When looking for display text, is it really necessary to
traverse the ancestors? Have you tried using top-down traversal
(api.getForegroundObject().whatever or looking for a window with a
specific class name and so on)?
Overall: App profiles will let you specify exactly what’s different
between normal config and the app version. I sometimes use this to
suppress progress bar beeps in TC Conference (Derek wrote a fix for that
a few months ago). In regards to coding style, Nick’s coding style
should be a textbook example of good use of line separation and use of
Python idioms. I recommend a green light for mIRC and Mush client app
modules. Thanks.
Cheers,
Joseph
