Hi Noelia and others,
Basic review results for ReadFeeds 3.0-dev:
* License and copyright: pass
* User experience: partial
* Security: pass
A potential showstopper bug found: if you are trying to open Feeds dialog
for the first time, Config says, "KeyError: 'addressFile'". You can open
this dialog, but the elements in that dialog would not be aligned correctly.
I suggest catching this case and use default config for this.
Code wise: is filterLabeledCtrl used anywhere besides getting the edit field
sizer? If not, you can either add the control to the managing sizer directly
(sHelper/whateverSizer.addItem/addLabeledControl(self, label, wx.TextCTRL),
or use whateverTextCtrl.control. Personally, I prefer to add the label
constant directly when adding controls instead of using a separate variable
to hold control labels (it's up to you, but NVDA Core uses the label
variable approach for readability).
A blinking green light due to the possible showstopper bug, otherwise looks
fine to me. I'd like to request someone else (one or two) to help me review
this add-on. Thanks.
Cheers,
Joseph
