[nanomsg] Re: [PATCH] Replace the built-in "test" target with "check"

  • From: Martin Sustrik <sustrik@xxxxxxxxxx>
  • To: nanomsg@xxxxxxxxxxxxx
  • Date: Sun, 03 Mar 2013 09:07:14 +0100

Hi Nir,


The built-in "test" target has few issues that cannot be fixed:

- It does not depend on the test executables, so you must run "make" and
   "make test".

Confirmed. Is this a bug in our build scripts or rather a deficiency of CMake/CTest?

This seems related: http://stackoverflow.com/questions/733475/cmake-ctest-make-test-doesnt-build-tests

- It does not print errors from failed tests by default. The workaround
   is to run "make test ARGS=--output-on-failure".

Yes. That's important. We've set up a CI for nanomsg (http://build.crossroads.io/waterfall). It's mixed with XS CI at the moment, but just ignore that for now. The bad thing is that results from tests are not visible from the GUI. This patch should solve that.

Btw, speaking of CI, don't you have a box that could serve as OSX build slave? So far there's no automated testing for OSX.

Martin

Other related posts: