[muscle] Re: VS: Patching MUSCLE to compile on AMD64
- From: "Jeremy Friesner" <jaf@xxxxxxxxxxxx>
- To: muscle@xxxxxxxxxxxxx
- Date: Sat, 28 Jan 2006 12:09:13 PST (-0800)
Hi Mika,
I noticed that also, and fixed it... all HashCode() implementations should
return uint32.
(It's not clear to me whether uint64s would be faster than uint32s on a 64-bit
chip, or the same speed, or slower -- but in any case, I think it's simplest
just to
use the same integer sizes on all architectures, and since 32-bit is most common
architecture these days, uint32 is my choice)
Jeremy
> Looking closely to the patch, it seems like not all the hash calculations
> return same type of variable... I think that is something you should
> investigate more.... I changed some of variables in my MUSCLE related client
> to 64-bit integers so it would work better on 64-bit machines if needed.
>
> > -----Alkuperäinen viesti-----
> > Lähettäjä: muscle-bounce@xxxxxxxxxxxxx [mailto:muscle-
> > bounce@xxxxxxxxxxxxx] Puolesta Lior Okman
> > Lähetetty: 28. tammikuuta 2006 18:07
> > Vastaanottaja: muscle@xxxxxxxxxxxxx
> > Aihe: [muscle] Patching MUSCLE to compile on AMD64
> >
> >
> > Hi,
> >
> >
> > Attached is a patch for making MUSCLE compile on AMD64.
> >
> > After applying this patch MUSCLE compiles, but I'm afraid I haven't done
> > any real testing on the result (other than the most basic - it runs and
> > MUSCLE clients can connect and send basic messages).
> >
> > Regards,
> > Lior
>
>
>
Other related posts:
