Re: [PATCH] vm_x86.dasc: support building on OS X 10.4 and 10.5 intel

  • From: Mike Pall <mike-1401@xxxxxxxxxx>
  • To: luajit@xxxxxxxxxxxxx
  • Date: Sun, 19 Jan 2014 13:01:44 +0100

Kyle J. McKay wrote:
> The .uleb128 pseudo op is not supported by the older assemblers
> included with OS X 10.4 and 10.5.  Since the values being
> encoded are in the range 0x00-0x7F, simply replace the .uleb128
> pseudo op with .byte instead since that's what .uleb128 would
> generate for values in that range.

That change is ok and has been applied.

> The -fno-stack-protector option is not recognized by the older
> compiler included with OS X 10.4.  Only add the option when
> running on OS X 10.5 or later.

But that one isn't. It's undoing 67773165 which was added because
Clang needs -fno-stack-protector, too. Checking the OS version
doesn't seem right. Alas, Clang doesn't support -dumpspecs, so the
GCC-style check doesn't work. I'd rather drop OSX 10.4 support.

--Mike

Other related posts: