Paul, There is a bug tracker on the googlecode page that you can look at. however, presenting bugs on the list is fine with me. Of course you can try anything you want. I always check new code before committikng it. It would be nice to have a better way to determine if a header or footer is too long. John On Thu, Aug 01, 2013 at 10:24:28AM +0100, Paul Wood (Torch) wrote: > Thanks John, > Is there a better way to log a bug? I realise it's not an important one, > but would prefer it does get forgotten. > With regard to the truncated footer/header I can add some code to nicely > truncate it before it is sent to liblouisudtml, but as it's still in > text and not braille the length will be a guess! Would you mind if I had > a go at either using the first line of how the heading is split in the > actual text or where it cuts it going back to a space etc. ? > > Paul > > On 31/07/2013 17:05, John J. Boyer wrote: > >The strange character in the contents is an unbreakable space. It would > >take some study of the code to see just what is happening. I don't think > >it has higher priority than some other bugs, such as broken Braille page > >numbers when formatFor utd. > > > >The check for buffer overflow in insert_widechars is a safety measure. > >Truncation of a running header or footer happens when it won't fit on > >the line, including the page number and necessary spaces. You just have > >to make sure that it isn't too long. > > > >John > > > >On Wed, Jul 31, 2013 at 04:33:49PM +0100, PaulWood wrote: > >>John, > >>Thanks for committing this. What do you think about the other issue with > >>the extra character on the Contents header? > >>I'm also looking at the problem of the running header finishing mid > >>word. centerHeadFoot uses insertWidechars which says it looks for > >>overflow but it doesn't seem to work on the running header anyway. > >>obviously it needs to go back to the last space if the next character > >>isn't a space. Forgive my lack of c programming knowledge and I haven't > >>got a debug setup, so I can't interrogate what it is doing. Could you > >>have a look? > >>Thanks > >>Paul > >> > >>On 29/07/2013 20:39, liblouisutdml@xxxxxxxxxxxxxx wrote: > >>>Revision: 0d189aa1a18a > >>>Branch: default > >>>Author: John Boyer <john.boyer@xxxxxxxxxxxxxxxxx> > >>>Date: Mon Jul 29 12:38:46 2013 > >>>Log: fixed problem with centering of headers and footers > >>>http://code.google.com/p/liblouisutdml/source/detail?r=0d189aa1a18a > >>> > >>>Modified: > >>>/liblouisutdml/transcriber.c > >>> > >>>======================================= > >>>--- /liblouisutdml/transcriber.c Mon Jul 29 12:12:03 2013 > >>>+++ /liblouisutdml/transcriber.c Mon Jul 29 12:38:46 2013 > >>>@@ -1567,22 +1567,22 @@ > >>>static int > >>>centerHeadFoot (widechar * toCenter, int length) > >>>{ > >>>- int leadingBlanks; > >>>- int trailingBlanks; > >>>- int numCells = ud->cells_per_line - pageNumberLength; > >>>- if (length > numCells) > >>>- length = numCells - 4; > >>>- leadingBlanks = (numCells - length) / 2; > >>>- trailingBlanks = numCells - leadingBlanks - length; > >>>- if (!insertCharacters (blanks, leadingBlanks)) > >>>- return 0; > >>>- if (!insertWidechars (toCenter, length)) > >>>- return 0; > >>>- if (!insertCharacters (blanks, trailingBlanks)) > >>>- return 0; > >>>- if (!insertWidechars (pageNumberString, pageNumberLength)) > >>>- return 0; > >>>- return 1; > >>>+ int leadingBlanks; > >>>+ int trailingBlanks; > >>>+ int numCells = ud->cells_per_line - (pageNumberLength*2); > >>>+ if (length > numCells) > >>>+ length = numCells - 4; > >>>+ leadingBlanks = ((numCells - length) / 2) + pageNumberLength; > >>>+ trailingBlanks = numCells - leadingBlanks - length + > >>>pageNumberLength; > >>>+ if (!insertCharacters (blanks, leadingBlanks)) > >>>+ return 0; > >>>+ if (!insertWidechars (toCenter, length)) > >>>+ return 0; > >>>+ if (!insertCharacters (blanks, trailingBlanks)) > >>>+ return 0; > >>>+ if (!insertWidechars (pageNumberString, pageNumberLength)) > >>>+ return 0; > >>>+ return 1; > >>>} > >>> > >>>static int > >>>For a description of the software, to download it and links to > >>>project pages go to http://www.abilitiessoft.com > >>For a description of the software, to download it and links to > >>project pages go to http://www.abilitiessoft.com > > -- > Paulw.torchtrust signature > > Paul Wood, Technical Services Leader > *Torch Trust* > Torch House, Torch Way, > Market Harborough, Leics. LE16 9HL, UK > Direct Line: *+44(0)1858 438269* > Tel: *+44(0)1858 438260*, Fax: *+44(0)1858 438275* > Email: paulw@xxxxxxxxxxxxxx <mailto:paulw@xxxxxxxxxxxxxx> > Website: www.torchtrust.org <http://www.torchtrust.org/> > > ____________________________________________________ > > Chief Executive: Dr Gordon Temple > Charity No. 1095904 > > Privileged/Confidential Information may be contained in this message. > If you are not the intended recipient please destroy this message > and kindly notify the sender by reply email. The computer from which > this mail originates is equipped with virus screening software. > However Torch Trust cannot guarantee that the mail and its attachments > are free from virus infection. > -- John J. Boyer; President, Chief Software Developer Abilitiessoft, Inc. http://www.abilitiessoft.com Madison, Wisconsin USA Developing software for people with disabilities For a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com