[liblouis-liblouisxml] Re: [liblouis/liblouis] f01a14: Changed logging to make lou_log and lou_logPrint n...
- From: Bert Frees <bertfrees@xxxxxxxxx>
- To: liblouis-liblouisxml@xxxxxxxxxxxxx
- Date: Mon, 26 May 2014 17:07:29 +0200
Looks good. Only comment I have is that we would like to keep
lou_logPrint public for now but make it deprecated. The reason is that
we are "saving" some API changes for a single major version update later
(liblouis 3.0.0). We don't want to make these changes now and do more
backwards incompatible changes in half a year. If you want I'll revert
that part of your changes involved and also update the documentation.
Thanks,
Bert
Michael Whapples writes:
> Branch: refs/heads/mwhapples_logging
> Home: https://github.com/liblouis/liblouis
> Commit: f01a14db0f9b4fe67ce1af503b39db43966c38ba
>
> https://github.com/liblouis/liblouis/commit/f01a14db0f9b4fe67ce1af503b39db43966c38ba
> Author: Michael Whapples <mwhapples@xxxxxxxxx>
> Date: 2014-05-21 (Wed, 21 May 2014)
>
> Changed paths:
> M liblouis/compileTranslationTable.c
> M liblouis/liblouis.h.in
> M liblouis/logging.c
> M liblouis/lou_translateString.c
> M liblouis/louis.h
> M liblouis/wrappers.c
>
> Log Message:
> -----------
> Changed logging to make lou_log and lou_logPrint not public
>
>
> Commit: 4c6f9fefcfa2013c947cfddef7278c67ce44693e
>
> https://github.com/liblouis/liblouis/commit/4c6f9fefcfa2013c947cfddef7278c67ce44693e
> Author: Michael Whapples <mwhapples@xxxxxxxxx>
> Date: 2014-05-26 (Mon, 26 May 2014)
>
> Changed paths:
> M liblouis/louis.h
>
> Log Message:
> -----------
> Changed type definition
>
>
> Commit: 6ec7e58df5cfb28e10788b047ae2ed8a14f9c259
>
> https://github.com/liblouis/liblouis/commit/6ec7e58df5cfb28e10788b047ae2ed8a14f9c259
> Author: Michael Whapples <mwhapples@xxxxxxx>
> Date: 2014-05-26 (Mon, 26 May 2014)
>
> Changed paths:
> M windows/liblouis.def
>
> Log Message:
> -----------
> Update some function exports
>
>
> Compare:
> https://github.com/liblouis/liblouis/compare/c8424a5f9f11...6ec7e58df5cf
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
Other related posts:
