[liblouis-liblouisxml] Re: [liblouis] r597 committed - Hungarian grade 1 improvements and extensive test hu1 harness: Thanks ...

  • From: Hammer Attila <hammera@xxxxxxxxx>
  • To: liblouis-liblouisxml@xxxxxxxxxxxxx
  • Date: Mon, 07 May 2012 20:02:51 +0200

Hy Mesar,

Thank you the commit, but after update with the 597th revision hu1.ctb table is doesn't pass right with the lou_checktable test. You unfortunately forgot change the 1367 dot number in the hu1.ctb file with 1356 dots, hu-chardefs.cti file is right. I sending a patch, I added the hu-chardefs.cti file include opcode in hu-exceptionwords.cti file. Without this opcode the hungarian harness related test producing some undefined character errors, possible this is already not need with the 598 revision. I sending the test results with showing the make check command in the tests directory.

Attila
Index: tables/hu1.ctb
===================================================================
--- tables/hu1.ctb      (revision 597)
+++ tables/hu1.ctb      (working copy)
@@ -101,7 +101,7 @@
 prepunc " 236
 postpunc " 356
 always ( 2346
-always ) 1367
+always ) 1356
 prepunc \x00ab 236
 postpunc \x00bb 356
 prepunc \x2018 236
Index: tables/hu-exceptionwords.cti
===================================================================
--- tables/hu-exceptionwords.cti        (revision 597)
+++ tables/hu-exceptionwords.cti        (working copy)
@@ -28,6 +28,7 @@
 # Attila Hammer <hammer.attila@xxxxxxxxxxx
 #If you have a Launchpad account, report table related requests with following 
bug tracker address: https://bugs.launchpad.net/belin
 
+include hu-chardefs.cti
 #This file containing exception words with different need appliing general 
hungarian combined braille letters, for example cs, ccs, ty, tty rules
 #cs, ccs related exceptions
 partword arccs 1-1235-14-146   For example arccsont, harccsoport, 
harccselekmény words
Making check in tables
make[1]: Entering directory `/usr/src/liblouis/tests/tables'
make[1]: Nothing to be done for `check'.
make[1]: Leaving directory `/usr/src/liblouis/tests/tables'
Making check in doctests
make[1]: Entering directory `/usr/src/liblouis/tests/doctests'
make[1]: Nothing to be done for `check'.
make[1]: Leaving directory `/usr/src/liblouis/tests/doctests'
Making check in harness
make[1]: Entering directory `/usr/src/liblouis/tests/harness'
make  en-GB-g2_harness.py hu1_harness.py letterDefTest_harness.py
make[2]: Entering directory `/usr/src/liblouis/tests/harness'
make[2]: Nothing to be done for `en-GB-g2_harness.py'.
make[2]: Nothing to be done for `hu1_harness.py'.
make[2]: Nothing to be done for `letterDefTest_harness.py'.
make[2]: Leaving directory `/usr/src/liblouis/tests/harness'
make[1]: Leaving directory `/usr/src/liblouis/tests/harness'
make[1]: Entering directory `/usr/src/liblouis/tests'
make  pass2 pass2_inpos present_progressive capitalized_word 
capitalized_with_sentance inpos_compbrl lastworditalafter en_gb_g1_italics 
letterDefTest \
          check_all_tables.pl check_endless_loop.pl multiple_table_path.pl 
make[2]: Entering directory `/usr/src/liblouis/tests'
make[2]: `pass2' is up to date.
make[2]: `pass2_inpos' is up to date.
make[2]: `present_progressive' is up to date.
make[2]: `capitalized_word' is up to date.
make[2]: `capitalized_with_sentance' is up to date.
make[2]: `inpos_compbrl' is up to date.
make[2]: `lastworditalafter' is up to date.
make[2]: `en_gb_g1_italics' is up to date.
make[2]: `letterDefTest' is up to date.
make[2]: Nothing to be done for `check_all_tables.pl'.
make[2]: Nothing to be done for `check_endless_loop.pl'.
make[2]: Nothing to be done for `multiple_table_path.pl'.
make[2]: Leaving directory `/usr/src/liblouis/tests'
make  check-TESTS
make[2]: Entering directory `/usr/src/liblouis/tests'
PASS: pass2
Expected 3, recieved 0 in index 4
Expected 1, recieved 0 in index 0
Expected 2, recieved 1 in index 1
Expected 3, recieved 2 in index 2
FAIL: pass2_inpos
string='greetings  ' cursor=10 (' ') expected=8 recieved=7 (' ')
XFAIL: present_progressive
PASS: capitalized_word
PASS: capitalized_with_sentance
PASS: inpos_compbrl
Expected: .,he sd x wasn't .alw ."w+ z expect$4
Received: .,he sd x wasn't .alw .work+ z expect$4
Diff: Expected '"' but recieved 'w' in index 23
Expected: _ER SAGTE ES __FUNKTION0RE NI4T', IMMER W0 ERWARTET.
Received: _ER SAGTE ES __FUNKTION0RE _NI4T IMMER W0 ERWARTET.
Diff: Expected 'N' but recieved '_' in index 27
XFAIL: lastworditalafter
Expected: ..,this is a ,test in ,italic4.'
Received: ,this is a ,test in ,italic4.'
Diff: Expected '.' but recieved ',' in index 0
Expected: ,this .is .a ,test
Received: ,this is a.' ,test
Diff: Expected '.' but recieved 'i' in index 6
XFAIL: en_gb_g1_italics
PASS: letterDefTest
PASS: check_all_tables.pl
PASS: check_endless_loop.pl
PASS: multiple_table_path.pl
=============================================
1 of 12 tests failed
Please report to john.boyer@xxxxxxxxxxxxxxxxx
=============================================
make[2]: Leaving directory `/usr/src/liblouis/tests'
make[1]: Leaving directory `/usr/src/liblouis/tests'

Other related posts: