[liblouis-liblouisxml] Re: LibLouis bug with largesign

  • From: Keith Creasy <kcreasy@xxxxxxx>
  • To: "liblouis-liblouisxml@xxxxxxxxxxxxx" <liblouis-liblouisxml@xxxxxxxxxxxxx>
  • Date: Wed, 12 Mar 2014 11:38:59 +0000

Michael.

Great work finding the problem. 

Using 0xff to demark segments seems like a hack really. For one thing it 
assumes I suppose that that value isn't used for something else.

The problem is the need to translate in context but keep the Braille associated 
with the correct text node. At the moment I can't think of a fool-proof way of 
doing that without such a delimiter.

Maybe John can do something that prevents LibLouis from stripping the delimiter.

-----Original Message-----
From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx 
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Michael Whapples
Sent: Wednesday, March 12, 2014 7:22 AM
To: liblouis-liblouisxml@xxxxxxxxxxxxx; brailleblaster@xxxxxxxxxxxxx
Subject: [liblouis-liblouisxml] LibLouis bug with largesign

Hello,
In tracking down the bug where liblouisutdml is putting the wrong Braille 
content in brl nodes, I have now worked out the actual code which is causing 
this issue.

Basically what seems to be the problem is that LibLouisUTDML processes a 
paragraph by adding each text segment of the paragraph into a single buffer, 
separating the segment with \xffff characters. Once the buffer contains the 
full paragraph text it translates it in one go, and then splits the text into 
the segments by searching for \xffff.

The problem is that if one has text which gets processed by a largesign optcode 
rule either side of the \xffff end segment separator (eg. "and
\xffffthe") then liblouis will remove the \xffff from between the largesign 
translations. Thus now when liblouisutdml takes the translation and splits it 
into segments for inserting into the appropriate brl nodes it will miss one of 
the split points.

Could someone point me at the code in liblouis which strips the characters 
between largesign words. Then I could make a fix fairly quickly.

I guess a longer term question I want to raise is whether this way of 
processing paragraphs is really a good plan?

Michael Whapples
For a description of the software, to download it and links to project pages go 
to http://www.abilitiessoft.com
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com

Other related posts: