I am fine with leaving the log file location to a later date. One can still use lou_logFile to set a log file location if they want to. Also if they want more complicated log file handling (eg. sending liblouis and liblouisutdml log to one file) then that is what the callback is for.
Please could you merge the logging branch. Thanks Michael Whapples On 09/06/2014 12:49, Bert Frees wrote:
Hello Michael, No, your branch should be ready for merging now. It's up to you if you want to do the default log file first or not. As long as we still have lou_logFile I don't find it that important that liblouis logs to a file by default, stderr is fine as a default for now. In any case, logging to the file should only be the default handler IMO, and disabled if a callback is set. We can help you with the configure option. The Java bindings are a separate matter. Thanks, Bert Michael Whapples writes:One thought which has crossed my mind is the default log file stuff. With my knowledge of linux a sensible default log file for liblouis might be /var/log/liblouis.log, however I feel may be this should be configurable when running ./configure (IE. do all distributions use that location). If it does need setting by ./configure I would need help with that. As I remember when discussing this before, on windows we concluded may be the temp folder. Should LibLouis write to that default log file even if a callback is set or is log file writing just the default handler/callback for logging? I have no strong view either way. Something similar probably should be done for liblouisutdml. What do people think? Michael Whapples On 09/06/2014 08:31, Michael Whapples (Redacted sender mwhapples@xxxxxxx for DMARC) wrote:Hello, I would like to ask whether there are any other changes which need to be made to the logging branch before it could be merged to master? If there are no other changes then may be we should look at merging it. I think as far as I can tell there are no further immediate changes I want making to the logging branch, I have liblouisutdml working with it as I want. The only possible thing would be move the liblouis stuff in the Java bindings of liblouisutdml into liblouis Java bindings (IE. actually create a set of official Java bindings for liblouis), but I think that would be taken as separate work in a different branch.For a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com
For a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com
