[irqbalance] Re: [RFC][PATCH 4/5] log: sane version of systemd-journal loglevels

  • From: Neil Horman <nhorman@xxxxxxxxxxxxx>
  • To: irqbalance@xxxxxxxxxxxxx
  • Date: Tue, 3 Mar 2015 16:07:11 -0500

On Tue, Mar 03, 2015 at 03:07:25PM -0500, Andrej Manduch wrote:
> Hi,
> 
> On 03/03/2015 02:19 PM, Neil Horman wrote:
> > On Tue, Mar 03, 2015 at 01:30:37PM -0500, Andrej Manduch wrote:
> >> Hi,
> >>
> >> That's weird because it seems to be working for me
> >>
> >> burlak@borg /m/c/irqbalance (master) $ git pull
> >> Already up-to-date.
> >> burlak@borg /m/c/irqbalance (master) $ git checkout -b test-patchet-journal
> >> Switched to a new branch 'test-patchet-journal'
> >> burlak@borg /m/c/irqbalance (test-patchet-journal) $ git log -n1
> >> commit d97006c50cd8024a9b308f371c37cdc8ced32cd7
> >> Merge: eeb1ea9 856435e
> >> Author: Neil Horman <nhorman@xxxxxxxxx>
> >> Date:   Thu Jan 22 09:32:06 2015 -0500
> >>
> >>     Merge pull request #16 from yangoliver/pci
> >>
> >>     Follow latest PCI class code spec
> >> burlak@borg /m/c/irqbalance (test-patchet-journal) $ git am
> >> \[RFC\]\[PATCH\ 1_5\]\ Added\ option\ for\ journal-style\ logging.eml
> >> Applying: Added option for journal-style logging
> >> burlak@borg /m/c/irqbalance (test-patchet-journal) $ git am
> >> \[irqbalance\]\ \[RFC\]\[PATCH\ 2_5\]\ Optimized\ indentation\ for\
> >> systemd\ journal.eml
> >> Applying: Optimized indentation for systemd journal
> >> burlak@borg /m/c/irqbalance (test-patchet-journal) $ git am
> >> \[RFC\]\[PATCH\ 3_5\]\ log\:\ added\ support\ for\ systemd-journal\
> >> loglevels.eml
> >> Applying: log: added support for systemd-journal loglevels
> >> burlak@borg /m/c/irqbalance (test-patchet-journal) $ git am
> >> \[irqbalance\]\ \[RFC\]\[PATCH\ 4_5\]\ log\:\ sane\ version\ of\
> >> systemd-journal\ loglevels.eml
> >> Applying: log: sane version of systemd-journal loglevels
> >> burlak@borg /m/c/irqbalance (test-patchet-journal) $ git am
> >> \[irqbalance\]\ \[RFC\]\[PATCH\ 5_5\]\ log\:\ systemd-style\ logs\ are\
> >> handled\ by\ systemd-lib.eml
> >> Applying: log: systemd-style logs are handled by systemd-lib
> >>
> >>
> >>
> >> Did you applied it in correct order ?
> >>
> > Yeah, I reversed 4 and 5 to put them in the correct order.  Let me try again
> > Neil
> > 
> 
> They are in correct order. I resended patch 4/5 only because it take too
> long to came to the list and I thought that mail got bounced from MTA or
> something.
> 
I must have done some application out of order, and didn't wait long enough
either, as its applying properly now.

Reviewing them, I'm ok with these patches, I'll push them shortly.

Neil

> order of patches is:
> [RFC][PATCH 1/5] Added option for journal-style logging
> [RFC][PATCH 2/5] Optimized indentation for systemd journal
> [RFC][PATCH 3/5] log: added support for systemd-journal loglevels
> [RFC][PATCH 4/5] log: sane version of systemd-journal loglevels
> [RFC][PATCH 5/5] log: systemd-style logs are handled by systemd-lib
> 
> 
> -- 
> Kind regards,
> b.
> 
> 

Other related posts: