Bob,
Last thing I noticed is to fix the "}" at the end of this line:
PRIORITY: [HIGH, MEDIUM, LOW] [LOW}
Thanks,
Randy
From: ibis-quality-bounce@xxxxxxxxxxxxx <ibis-quality-bounce@xxxxxxxxxxxxx> On
Behalf Of Bob Ross
Sent: Tuesday, January 19, 2021 7:03 PM
To: mlabonte@xxxxxxxxxx; ibis-quality@xxxxxxxxxxxxx
Cc: bob@xxxxxxxxxxxxxxxxx
Subject: [ibis-quality] Re: [EXT] RE: TSCHK2 Enhancement
CAUTION: EXTERNAL EMAIL. Do not click links or open attachments unless you
recognize the sender and were expecting this message.
Mike,
Thanks. I fixed this and other issues in draft3.
Bob
From:
ibis-quality-bounce@xxxxxxxxxxxxx<mailto:ibis-quality-bounce@xxxxxxxxxxxxx>
[mailto:ibis-quality-bounce@xxxxxxxxxxxxx] On Behalf Of Mike LaBonte
Sent: Tuesday, January 19, 2021 5:16 PM
To: ibis-quality@xxxxxxxxxxxxx<mailto:ibis-quality@xxxxxxxxxxxxx>
Subject: [ibis-quality] Re: [EXT] RE: TSCHK2 Enhancement
The testcase file is labeled as "bug4.ts" but the command line is shown as
"tschk2.exe -canonical-v1 tschk2_test.ts > tschk2_test.s2p".
Mike
On 1/19/2021 5:29 PM, Bob Ross wrote:
Randy,
Attached is the revised bug4 draft 2 before I upload it. I simplified the
numbers to make bug4.txt more readable and add a statement that an exact
numerical match is required.
Bob
From:
ibis-quality-bounce@xxxxxxxxxxxxx<mailto:ibis-quality-bounce@xxxxxxxxxxxxx>
[mailto:ibis-quality-bounce@xxxxxxxxxxxxx] On Behalf Of Randy Wolff ;(Redacted
sender "rrwolff" for DMARC)
Sent: Friday, January 15, 2021 3:19 PM
To: Bob Ross; ibis-quality@xxxxxxxxxxxxx<mailto:ibis-quality@xxxxxxxxxxxxx>
Subject: [ibis-quality] Re: [EXT] RE: TSCHK2 Enhancement
Bob,
We can discuss Tuesday if it's on the Quality task group agenda.
I've been using the [Matrix Format] Upper/Lower to reduce the file size for
many S-parameters that are reciprocal.
I'm not sure the best approach for matching numbers.
Randy
From: Bob Ross <bob@xxxxxxxxxxxxxxxxx><mailto:bob@xxxxxxxxxxxxxxxxx>
Sent: Friday, January 15, 2021 2:44 PM
To: Randy Wolff (rrwolff) <rrwolff@xxxxxxxxxx><mailto:rrwolff@xxxxxxxxxx>;
ibis-quality@xxxxxxxxxxxxx<mailto:ibis-quality@xxxxxxxxxxxxx>
Cc: bob@xxxxxxxxxxxxxxxxx<mailto:bob@xxxxxxxxxxxxxxxxx>
Subject: [EXT] RE: [ibis-quality] TSCHK2 Enhancement
CAUTION: EXTERNAL EMAIL. Do not click links or open attachments unless you
recognize the sender and were expecting this message.
Randy,
We can discuss and file this.
I need to look at the example further regarding [Matrix Format] Lower
Also, when does 49.99999 equal 50?
Bob
From:
ibis-quality-bounce@xxxxxxxxxxxxx<mailto:ibis-quality-bounce@xxxxxxxxxxxxx>
[mailto:ibis-quality-bounce@xxxxxxxxxxxxx] On Behalf Of Randy Wolff ;(Redacted
sender "rrwolff" for DMARC)
Sent: Friday, January 15, 2021 9:44 AM
To: ibis-quality@xxxxxxxxxxxxx<mailto:ibis-quality@xxxxxxxxxxxxx>
Subject: [ibis-quality] TSCHK2 Enhancement
******************************************************************************
****************** TSCHK TOUCHSTONE PARSER BUG REPORT FORM *******************
******************************************************************************
INSTRUCTIONS
To report a bug in the TSCHK Touchstone Parser. Please fill out the top part
of the following form and send the complete form to
info@xxxxxxxx<mailto:info@xxxxxxxx>.
A list of reported bugs is maintained at
http://ibis.org/bugs/tschk<https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fibis.org%2Fbugs%2Ftschk&data=04%7C01%7Crrwolff%40micron.com%7Cbd6e52dbd41341a154b008d8bce78124%7Cf38a5ecd28134862b11bac1d563c806f%7C0%7C0%7C637467049786620722%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pJq%2BRDTNUVAfgbJa7e7zOUpGkEd7R%2BFglwObCifDcbc%3D&reserved=0>.
******************************************************************************
PARSER VERSION NUMBER: 2.0.0
PLATFORM (SPARC, HP700, PC, etc.): PC
OS AND VERSION: Windows 10
REPORTED BY: Randy Wolff, Micron Technology
DATE: 1/15/2021
DESCRIPTION OF BUG:
TSCHK2 was used to attempt conversion of a Touchstone 2 file to a Touchstone 1
file with
the following command:
tschk2.exe -canonical-v1 tschk2_test.ts > tschk2_test.s2p
and the output was:
tschk2: failed to write Touchstone v1 file: Touchstone v1 only supports a
single reference impedance
Looks like the conversion routine doesn't recognize that this line in the
Touchstone 2 file:
[Reference] 50 50
is still a single reference impedance. I think any use of the [Reference]
keyword breaks the
conversion, as it assumes it is being used to show different per-port
impedances. For this file
example, adding a "!" comment to the [Reference] line allows for a successful
file conversion.
A simple enhancement would check the [Reference] line to see if all values are
the same,
in which case it could go forward with the conversion.
INSERT TOUCHSTONE FILE DEMONSTRATING THE BUG:
! NPort=2 DATA=1 NOISE=0 GROUPDELAY=0 COMPLEX_DATAFORMAT=DB
! Ports List
! Port# Port Name
! 1 IN
! 2 OUT
!
[Version] 2.0
# Hz S DB R 50
[Number of Ports] 2
[Two-Port Data Order] 12_21
[Number of Frequencies] 3
[Reference] 50 50
[Matrix Format] Lower
[Network Data]
1 -27.77074664 0.1611905264
-0.3979214136 -0.006873940006 -27.63286365 0.1575499859
52632.52632 -27.73466757 0.2704729716
-0.3994660425 -0.03026474687 -27.59758975 0.2485036209
105264.0526 -27.71976049 0.2537333701
-0.4001114298 -0.04821472669 -27.58299785 0.2162427882
[End]
******************************************************************************
******************** BELOW FOR ADMINISTRATION AND TRACKING *******************
******************************************************************************
BUG NUMBER:
SEVERITY: [FATAL, SEVERE, MODERATE, ANNOYING, ENHANCEMENT]
PRIORITY: [HIGH, MEDIUM, LOW]
STATUS: [OPEN, CLOSED, WILL NOT FIX, NOT A BUG]
FIXED VERSION:
FIXED DATE:
NOTES ON BUG FIX:
******************************************************************************
******************************************************************************
