[hipl-dev] Re: [Merge] lp:~hipl-core/hipl/ipsec-cleanup into lp:hipl
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: hipl-dev@xxxxxxxxxxxxx
- Date: Thu, 13 Jan 2011 19:05:59 +0100
review approve
On Thu, Jan 13, 2011 at 04:32:29PM +0000, René Hummen wrote:
>
> This branch
> 1) fixes https://bugs.launchpad.net/hipl/+bug/699730,
> 2) unifies setting up IPsec SAs and removes redundant code, and
> 3) removes update functionality for kernel-space IPsec SAs.
>
> I performed change (3), as XFRM_MSG_NEWSA was issued for updates, while
> XFRM_MSG_UPDSA after BEX (notice wrong semantics). Furthermore, old SAs of a
> connection are always removed before setting up the new ones. I didn't notice
> any mobility delays, after switching to XFRM_MSG_NEWSA only.
I did not notice anything out of the ordinary, just the following nit:
> --- modules/update/hipd/update.c 2011-01-11 13:59:46 +0000
> +++ modules/update/hipd/update.c 2011-01-13 16:32:12 +0000
> @@ -934,10 +934,10 @@
>
> // don't update IPsec SAs and SPs for 1st UPDATE packet
> - if (!hip_get_param(ctx->input_msg, HIP_PARAM_LOCATOR)) {
> + if(!hip_get_param(ctx->input_msg, HIP_PARAM_LOCATOR)) {
if (
Forgot to enable uncrustify? :)
Diego
Other related posts:
