[hipl-dev] [Bug 795848] Re: starting of daemons from binary packages when they are down

  • From: David Martin <795848@xxxxxxxxxxxxxxxxxx>
  • To: hipl-dev@xxxxxxxxxxxxx
  • Date: Tue, 21 Jun 2011 13:21:15 -0000

There have been two problems with the scripts:

> 1.0.6-5964_amd64.deb) ...
> * Stopping DNS proxy for HIP hipdnsproxy
>   ...fail!
> invoke-rc.d: initscript hipl-dnsproxy, action "stop" failed.
> dpkg: warning: old pre-removal script returned error exit status 1

In this case start-stop-daemon which is used to stop the daemon returns
1 if the daemon is not running and it is treated as an error during
installation. Using the option --oknodo fixes this.


> Preparing to replace hipl-firewall 1.0.6-2 (using 
> .../hipl-firewall_1.0.6-5964_amd64.deb) ...
>  * Stopping HIP firewall hipfw
> invoke-rc.d: initscript hipl-firewall, action "stop" failed.
> dpkg: warning: old pre-removal script returned error exit status 2

In this case it's the flushing of the firewall rules which returns
status 2. We are using 'set -e' so any unchecked command returning
nonzero exits the script. Checking the return value of the
flush_iptables function fixes this problem.

I have committed the changes in trunk revisions 5968 and 5969 and on my
machine it works without problems. Can you check if it's the same for
you Miika?

PS: The flags notice of the firewall seems to be just a warning and no
error. We are using the option -F to accept all HIP traffic. This means
we are not dealing with authentications and this is why specifying any
timeouts for them won't have an effect.

-- 
You received this bug notification because you are a member of HIPL core
team, which is subscribed to HIPL.
https://bugs.launchpad.net/bugs/795848

Title:
  starting of daemons from binary packages when they are down

Status in Host Identity Protocol for Linux:
  Confirmed

Bug description:
  It appears that the init.d scripts don't work anymore as they used to.
  When a daemon is down, a package upgrade fails:

  Preparing to replace hipl-dnsproxy 1.0.6-2 (using 
.../hipl-dnsproxy_1.0.6-5964_amd64.deb) ...
   * Stopping DNS proxy for HIP hipdnsproxy
     ...fail!
  invoke-rc.d: initscript hipl-dnsproxy, action "stop" failed.
  dpkg: warning: old pre-removal script returned error exit status 1
  dpkg - trying script from the new package instead ...
   * Stopping DNS proxy for HIP hipdnsproxy
     ...fail!
  invoke-rc.d: initscript hipl-dnsproxy, action "stop" failed.
  dpkg: error processing 
/var/cache/apt/archives/hipl-dnsproxy_1.0.6-5964_amd64.deb (--unpack):
   subprocess new pre-removal script returned error exit status 1
   * Starting DNS proxy for HIP hipdnsproxy
     ...done.
  Preparing to replace hipl-firewall 1.0.6-2 (using 
.../hipl-firewall_1.0.6-5964_amd64.deb) ...
   * Stopping HIP firewall hipfw
  invoke-rc.d: initscript hipl-firewall, action "stop" failed.
  dpkg: warning: old pre-removal script returned error exit status 2
  dpkg - trying script from the new package instead ...
   * Stopping HIP firewall hipfw
  invoke-rc.d: initscript hipl-firewall, action "stop" failed.
  dpkg: error processing 
/var/cache/apt/archives/hipl-firewall_1.0.6-5964_amd64.deb (--unpack):
   subprocess new pre-removal script returned error exit status 2
   * Starting HIP firewall hipfw
  Warning: timeouts (-t) have no effect with connection
           tracking disabled (-F)
     ...done.

  Upgrading the package when the daemon is up and running succeeds, but
  nevertheless even this case should be working (as it used to be).
  Please note also the warning about the firewall (somebody changed the
  flags?).

To manage notifications about this bug go to:
https://bugs.launchpad.net/hipl/+bug/795848/+subscriptions

Other related posts: