[hipl-dev] [Bug 790679] Re: Minor segfault on failed startup

  • From: Jookos <790679@xxxxxxxxxxxxxxxxxx>
  • To: hipl-dev@xxxxxxxxxxxxx
  • Date: Wed, 01 Jun 2011 11:35:05 -0000

Probably not, as hip_xfrmapi_nl_ipsec is static to xfrmapi.c ;)

But ok, another option is to re-organize the initialization so that that
variable gets set before it is possible to abort the initialization.
Basically move the hip_xfrm_set_nl_ipsec() call to somewhere before the
first HIP_IFEL.

.. I'll attach a patch now that I actually tried it out.


** Patch added: "Move setting of the nl_ipsec to the start of hipd_init"
   
https://bugs.launchpad.net/hipl/+bug/790679/+attachment/2150486/+files/nl_ipsec_init.patch

-- 
You received this bug notification because you are a member of HIPL core
team, which is subscribed to HIPL.
https://bugs.launchpad.net/bugs/790679

Title:
  Minor segfault on failed startup

Status in Host Identity Protocol for Linux:
  New

Bug description:
  If the kernel module checks during startup fails, hipd segfaults
  instead of exiting nicely. This because the hip_xfrmapi_nl_ipsec
  (lib/tool/xfrmapi.c:49) hasn't been initialized before it is used in
  hip_delete_hit_sp_pair() [which is called on exit].

  quick & dirty patch attached

Other related posts: