[hipl-dev] [Bug 697561] Re: hip_hadb_find_by_hits has non-descriptive function parameter names
- From: Miika Komu <697561@xxxxxxxxxxxxxxxxxx>
- To: hipl-dev@xxxxxxxxxxxxx
- Date: Wed, 05 Jan 2011 09:58:03 -0000
Src and dst are better but still depend on view point. I think e.g.
"local" and "remote" (or "our" and "peer") disambiguate the situation.
--
You received this bug notification because you are a member of HIPL core
team, which is subscribed to HIPL.
https://bugs.launchpad.net/bugs/697561
Title:
hip_hadb_find_by_hits has non-descriptive function parameter names
Status in Host Identity Protocol for Linux:
New
Bug description:
>>>> debug(hipd/hadb.c:251@hip_hadb_find_byhits): HIT1:
>>>> 2001:001a:7139:10ad:bb56:f1d3:d3d1:83c4
>>>> debug(hipd/hadb.c:252@hip_hadb_find_byhits): HIT2:
>>>> 2001:001a:d834:7a17:1b02:5030:a412:5dfd
"HIT1" to "Initiator" and "HIT2" to "Responder" or "source HIT" and
"destination HIT" or something along the way.
Even in the function parameters (hip_hadb_find_byhits) it would make more sense
to use descriptive parameter names, such as hit_src and hit_dst, rather than
hit1 and hit2.
Other related posts:
