[hipl-dev] [Bug 1554072] Re: midauth extensions are broken

  • From: Christof Mroz <1554072@xxxxxxxxxxxxxxxxxx>
  • To: hipl-dev@xxxxxxxxxxxxx
  • Date: Wed, 09 Mar 2016 14:25:17 -0000

You're right; changing this line to the following seems to compile at
least (still untested):

scratch_buffer.ipq = *(ctx->ipq_packet);

Copying the ipq struct may not even be necessary at all: perhaps it
suffices to reset the payload pointer and overwrite the old struct,
since it seems to get reconstructed for every packet anyway.

-- 
You received this bug notification because you are a member of HIPL core
team, which is subscribed to HIPL.
https://bugs.launchpad.net/bugs/1554072

Title:
  midauth extensions are broken

Status in HIPL:
  New

Bug description:
  I am trying to run the midauth extensions by running the hipfw at the
  initiator and responder with the following options:

  hipfw/hipfw -kpdAm

  However, the base exchange just fails unless a turn on the following
  flag:

  mkomu@gaijin:~/projects/hipl-bzr/trunk$ bzr diff
  === modified file 'hipfw/rewrite.c'
  --- hipfw/rewrite.c   2013-08-19 18:30:29 +0000
  +++ hipfw/rewrite.c   2016-02-26 10:13:27 +0000
  @@ -140,7 +140,7 @@
       HIP_ASSERT(ctx);
       HIP_ASSERT(ctx->ipq_packet);
   
  -    if (assume_ipq_buffer_sufficient) {
  +    if (!assume_ipq_buffer_sufficient) {
           hip_fw_context_enable_write_inplace(ctx);
           return;
       }

  Any ideas to fix it properly would be appreciated.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hipl/+bug/1554072/+subscriptions

Other related posts: