[hipl-dev] Re: [Branch ~hipl-core/hipl/trunk] Rev 5969: Do not exit on iptable flush error in hipfw init script.
- From: David Martin <david.martin.mailbox@xxxxxxxxxxxxxx>
- To: hipl-dev@xxxxxxxxxxxxx
- Date: Tue, 21 Jun 2011 15:56:03 +0200
Hi,
>> > Were you trying to manually implement the '--fixes' option to
>> > 'bzr commit'?
>>
>> Nope, it's just that there are two commits to fix the bug. Should I
>> use --fixes for both then? (I would have mentioned the bugreport in
>> any case though)
>
> I assume that the second one actually closes the bug, so that would be
> the natural point to use --fixes IMO; both might work as well.
well, time to start experimenting. I'll see what happens next time.
>> Where does the option have an effect anyway? At some point it used to
>> be displayed in the bug report itself but that does not seem to be the
>> case anymore.
>
> The option causes the bug data to be stored in the Bazaar metadata,
> that's a worthwhile goal in itself IMO.
True.
On Tue, Jun 21, 2011 at 3:42 PM, Miika Komu <mkomu@xxxxxxxxx> wrote:
> --fixes is good practice, but IMHO it does not hurt to have bug number
> redundantly in the body of the commit either.
Yup, think so too.
David
Other related posts:
