[haiku-development] Re: [PATCH] Remove text cursor from bootloader menu screens

  • From: "David Powell" <david@xxxxxxxxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 2 Jul 2008 17:04:32 +0100

2008/7/2 Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>:
>
> Thanks, I've applied it in r26222.

Cheers. :-)

> BTW please don't send patches as part of HTML mails; at least my BeOS
> "patch" gets confused by the MIME parts and cannot apply the patch,
> then.

Oops, sorry about that. I'm using GMail and didn't realise that I was
sending nasty HTML e-mails.
I'll fix it now. If you get another HTML mail from me please let me know.

>
> > I also changed a couple of the register assignments to make them
> > clearer.
> > (They confused me initially)
>
> Not sure why it confused you (eax/... is 32bit wide, anyway), but I
> applied the patch as is anyway :-)

it was the line 'regs.eax = 3' that threw me. It took me a while to
work out that AH was being loaded with 0x00 and
therefore the video BIOS interrupt was a mode change. Obvious from the
comment above the code, but I was having
problems with my own code not working at the time and thought
(incorrectly) I was having little/big endian problems.
I've not called a BIOS interrupt in over 10 years. I'm a little rusty. ;-)

David.

Other related posts: