[haiku-development] Re: MBR code in r33263
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Thu, 06 May 2010 17:56:06 +0200
André Braga <meianoite@xxxxxxxxx> wrote:
> On 27 April 2010 03:42, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> > Michael has introduced André Braga's new FreeBSD derived MBR boot
> > code.
> > Unfortunately, there is only the machine code - can we have the
> > assembler sources in our repository as well in order to be able to
> > make
> > changes to it? (or at least be able to read it)
> FWIW, the sources were attached to ticket #4028
> [http://dev.haiku-os.org/ticket/4028] and as of r36535 (latest that I
> checked) there is a bug in
> src/add-ons/kernel/partitioning_systems/intel/PartitionMapWriter.cpp.
> The hex code is missing 8 bytes, or a quadword that indicates the
> number of sectors that the GPT code loads (on haiku_gpt_mbr.S, line
> 145), and those are never written back anywhere else on the code.
[...]
> P.s.: Attached to this message is a version that has fixed comments
> and better formatting of the code and comments (4 spaces per tab); no
> functional changes. I'm updating the ticket as well.
Thanks! I'll look into putting it in our repository once I find the
time.
Bye,
Axel.
Other related posts: