[haiku-commits] Re: r43033 - haiku/trunk/src/add-ons/kernel/file_systems/bfs
- From: François Revol <revol@xxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 31 Oct 2011 21:36:21 +0100
Le 31/10/2011 18:39, Axel Dörfler a écrit :
> On 10/31/2011 02:33 PM, revol@xxxxxxx wrote:
>> Log:
>> Add creation of a be:volume_id attribute on the root node as BeOS did,
>> based on a patch by phcoder. Thanks!
>
> Looks almost fine in general, but what happened to the coding style police?
It was busy looking at others :D
>> + Transaction transaction(this, fRootNode->BlockNumber());
>> + fRootNode->WriteLockInTransaction(transaction);
>> + attr.Write(transaction, cookie, 0, (uint8_t *)&id,&len, NULL);
>
> No space after cast again, no space before the asterisk.
> Besides, this is all wrong: it should get the transaction from its
> caller, or else this won't work right when called from the initializer.
That I was wondering, but since in one place it has a transaction opened
already and another not...
François.
Other related posts:
