[haiku-commits] Re: r42725 - in haiku/trunk/src/add-ons/kernel/generic: ata_adapter ide_adapter
- From: Alexander von Gluck <kallisti5@xxxxxxxxxxx>
- To: <haiku-commits@xxxxxxxxxxxxx>
- Date: Thu, 08 Sep 2011 13:28:01 -0500
On Thu, 08 Sep 2011 20:11:07 +0200, Axel Dörfler wrote:
On 08.09.2011 17:47, kallisti5@xxxxxxxxxxx wrote:
* changing to cpp uncovered a few bugs in ide_adaptor
* correct losing signed integer
There don't seem to be any bugs that you fixed - what are you
referring to?
Well, not really large bugs.. passing uint's to things that took
vint's, etc.
They were already corrected in ata_adapter but not ide_adapter.
* gcc2 build now fixed after r42724
Are you sure? It looks like you actually broke ide_adapter as you
obviously renamed all occurrences of ide_channel to ideChannel which
also happens to be a field name.
Always compile before you commit!
The original breakage was because I compiled in gcc4 and not gcc2
before committing.
<strike>r42725 should compile fine</strike>
uugh. I see what your saying.
I missed a header and didn't adjust ide_channel in the bus drivers.
As ide is no longer included by default.. i missed that breakage.
fixing.
Sorry for the mess.
Thanks!
-- Alex
Other related posts:
