[haiku-commits] Re: r42472 - haiku/trunk/src/servers/app

  • From: Clemens <clemens.zeidler@xxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 25 Jul 2011 09:11:23 +1200

On Mon, 25 Jul 2011 00:08:29 +1200, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
* It helps a lot to find thread problems when the multi locker assert macros actually doing something useful. Took me forever to finally realise that and 
to find a threading bug.


I wonder how long those are broken; they definitely worked at some point.
first I accused myself, thought I was to lazy to fix it properly when running in debug mode but trac says I'm innocent. Seams it never has been committed!? 




* Remove a superfluously assert which sends the app server into the
debugger. More fixes following.
It's not superfluous, but it only works in full debug mode, ie. when the multi locker also tracks the read locks which it usually doesn't do for performance reasons. 



ah ok, but this should be the case when defining DEBUG 1 right?
http://dev.haiku-os.org/browser/haiku/trunk/src/servers/app/MultiLocker.h?rev=42472
At least the assert was a bit misplaced IMHO. The Workspace constructor does not do anything outside the class, thus nothing has to be locked. 

Regards,
        Clemens

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 07-2011