[haiku-commits] Re: r42231 - haiku/trunk/src/apps/showimage
- From: Jon Yoder <darkwyrm@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 18 Jun 2011 07:25:42 -0400
On 06/18/2011 12:46 AM, leavengood@xxxxxxxxx wrote:
Author: leavengood
Date: 2011-06-18 06:46:37 +0200 (Sat, 18 Jun 2011)
New Revision: 42231
Changeset: https://dev.haiku-os.org/changeset/42231
Ticket: https://dev.haiku-os.org/ticket/6772
Modified:
haiku/trunk/src/apps/showimage/ShowImageView.cpp
Log:
Make the delete key clear the selection in selection mode, trash the file
otherwise.
Fixes #6772.
This is a bad idea, usability-wise. The Escape key already does this, so
having the Delete key also do it is unnecessary. Add to the fact that it
only does this when there is a selection. The Delete key should only
trash the file. Having extra modes, especially without the necessary
feedback, is confusing and potentially dangerous for data. I'd
appreciate it if you'd consider reverting this.
--Jon
Other related posts:
