[haiku-commits] Re: r41247 - haiku/trunk/src/libs/compat/freebsd_wlan/net80211

  • From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 13 Apr 2011 21:54:36 +0200

2011/4/13 Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>:
> korli@xxxxxxxxxxxxxxxx wrote:
>> +#if defined(__HAIKU__)
>> +     ieee80211_ratectl_attach(ic);
>> +#endif
>
> I wonder where this is done in FreeBSD.

There is a mapping between ratecontrol modules types and modules
names, the code loads the module when it's not registered.
The crypto part in net80211 also "loads" modules statically on
attachment when built on Haiku.

>
>>  #define TRACE_WLAN
>>  #ifdef TRACE_WLAN
>> -#    define TRACE(x, ...) dprintf(x, __VA_ARGS__);
>> +#    define TRACE(x...) dprintf(x);
>>  #else
>> -#    define TRACE(x, ...) ;
>> +#    define TRACE(x...) ;
>>  #endif
>
> What's the purpose of this change? The new code is a GCC extension,
> while the old code is actually how the standard requests it.

I don't remember well as I had this change long standing. I'll revert this part.

Bye,
Jérôme

Other related posts: