[haiku-commits] Re: r41185 - haiku/trunk/src/apps/screenshot

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 05 Apr 2011 21:23:56 +0200

humdingerb@xxxxxxxxxxxxxx wrote:
>       BGridLayout* gridLayout = BGridLayoutBuilder(0.0, 5.0)
>               .Add(fDelayControl->CreateLabelLayoutItem(), 0, 0)
>               .Add(fDelayControl->CreateTextViewLayoutItem(), 1, 0)
> -             .Add(seconds, 2, 0)     
> +             .Add(BSpaceLayoutItem::CreateHorizontalStrut(5), 2, 0)

Instead of using fixed spacings, you should always make it depend on 
the font size. The best way to do this is to utilize BControlLook::
DefaultItemSpacing(), and in this case maybe rather BControlLook::
DefaultLabelSpacing().

Bye,
   Axel.


Other related posts: