[haiku-commits] Re: r40524 - haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn

  • From: Alex Wilson <yourpalal2@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 15 Feb 2011 16:32:11 -0700

On Tue, Feb 15, 2011 at 4:05 PM, <kallisti5@xxxxxxxxxxx> wrote:

> Author: kallisti5
> Date: 2011-02-16 00:05:10 +0100 (Wed, 16 Feb 2011)
> New Revision: 40524
> Changeset: http://dev.haiku-os.org/changeset/40524
>
> Modified:
>
> haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/InterfaceAddressView.cpp
>
> haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/InterfaceAddressView.h
> Log:
> use grid layout builder
>
>
>        AddChild(BGroupLayoutBuilder(B_VERTICAL, 10)
> -               .Add(fModeField)
> -               .Add(fAddressField)
> -               .Add(fNetmaskField)
> -               .Add(fGatewayField)
> +               .Add(BGridLayoutBuilder()
> +                       .Add(fModeField->CreateLabelLayoutItem(), 0, 0)
> +                       .Add(fModeField->CreateMenuBarLayoutItem(), 1, 0)
> +                       .Add(fAddressField->CreateLabelLayoutItem(), 0, 1)
> +                       .Add(fAddressField->CreateTextViewLayoutItem(), 1,
> 1)
> +                       .Add(fNetmaskField->CreateLabelLayoutItem(), 0, 2)
> +                       .Add(fNetmaskField->CreateTextViewLayoutItem(), 1,
> 2)
> +                       .Add(fGatewayField->CreateLabelLayoutItem(), 0, 3)
> +                       .Add(fGatewayField->CreateTextViewLayoutItem(), 1,
> 3)
> +               )
>                .AddGlue()
> -               .SetInsets(10, 10, 10, 10)
>        );
>  }
>
>
If you switch to the templatized layout builders in <LayoutBuilder.h> you
get methods specifically for adding textview/menuField layout items
seprately, as well as slightly nicer / more efficient code (less BViews
created). The syntax is similar:

BLayoutBuilder::Group<>(this) // assuming this is a BGroupView or derivative
    .Add(...)
    //  ....
    .AddGrid()
          .AddMenuField(...) // etc...
          // ....
          .End()
     .AddGlue();

-Alex

Other related posts: