[haiku-commits] Re: r40311 - in haiku/trunk/src/tests/kits/net/preflet: . InterfacesAddOn
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 28 Jan 2011 23:26:27 +0100
Stephan Aßmus <superstippi@xxxxxx> wrote:
> > + BPoint namePt = BPoint(32+12, fFirstlineOffset);
Why not directly use the constructor like this:
BPoint namePt(32+12, fFirstlineOffset);
If a shorter solution is more readable than a longer solution, always
prefer the shorter version :-)
> > - menu->AddItem(new BMenuItem(B_TRANSLATE("Delete"),
> > - new BMessage(DELETE_PROFILE_MSG)));
> I am guessing this option should eventually allow to delete the
> currently selected/active profile. At least it makes sense to me. :-)
I wondered about that, too, but hoped he knew what he did.
But while we're at it, what is that "prevent changes" check box for?
It's completely unclear to me, so it should either be removed, or get a
better label IMO.
Bye,
Axel.
Other related posts:
