[haiku-commits] Re: r40011 - haiku/trunk/src/apps/stylededit

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 30 Dec 2010 17:58:55 +0100

Am 29.12.2010 06:16, schrieb leavengood@xxxxxxxxx:
Author: leavengood
Date: 2010-12-29 06:16:42 +0100 (Wed, 29 Dec 2010)
New Revision: 40011
Changeset: http://dev.haiku-os.org/changeset/40011

Modified:
    haiku/trunk/src/apps/stylededit/StyledEditWindow.cpp
Log:
CID 6931 and 8076: use strncpy for the extremely unlikely case that
B_TRANSLATE("???") returns something larger than the size of name.

I think this stuff is even in our coding guide lines. It doesn't matter if it's unlikely or not, it's simply unsafe code, i.e. a security issue waiting to happen.

Best regards,
-Stephan


Other related posts: