[haiku-commits] Re: r39707 - haiku/trunk/src/servers/app
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 04 Dec 2010 12:03:21 +0100
On 2010-12-03 at 21:10:55 [+0100], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
wrote:
> AFAIR fMouseEventWindow was only used in _SetWorkspace() and nowhere
> else. I originally added it with a broader scope in mind (hence its
> name), but it didn't turn out to be used this way until your changes.
It actually was used in exactly this way in
DefaultWindowBehaviour::MouseDown(). I just extended that to also happen in
ModifiersChanged().
> The "moveFocusWindow" argument had been added later, and indeed should
> have replaced the previous "unexpected side effect" which I obviously
> missed when I introduced it.
I wonder whether a commment might have helped. :-)
> Anyway, of course it would be nice if everything was properly
> implemented, it's just not always the case when you try to get things
> done with limited time.
I don't expect everything to be implemented perfectly, just that things
either have obvious semantics or do at least have a minimum amount of
comments/documentation when non-obvious things happen. In the end that
saves time (usually other people's time).
> It's not that this code is overly complicated.
Surprisingly that's rarely the case for code one has written oneself. :-P
CU, Ingo
Other related posts:
